search

mne-tools / mne-gsoc2018-3d

Sandbox for GSoC 2018 3D Viz
BSD 3-Clause "New" or "Revised" License
9 stars 4 forks source link

How to deal with multiple views and hemi #26

Open OlehKSS opened 6 years ago

OlehKSS commented 6 years ago

In PySurfer you can do hemi='lh' | 'rh' | 'both' | 'split', as well as views='lat' or views=['lat', 'med'].

Hopefully IPyvolume gives you some way of having multiple sub-panels/sub-scenes in a single rendering context (i.e., a 2x2 grid where each panel in the grid has its own objects and camera controls). If it already has these mechanisms the translation should be straightforward.

If it does not, then please open an IPyvolume issue discussing this use case so we can discuss potential solutions.

agramfort commented 6 years ago

i agree it would be neat but let's shoot for the 90% use cases. So maybe views=['lat', 'med'] is not necessary at this stage

my 2c

larsoner commented 6 years ago

I think it might fit within that. I frequently use hemi='split', views=['lat', 'med'] to look at data. You see the whole brain (approximately) at once), rather than 1/4 of it.

If it's not supported easily in ipyvolume, though, I agree that it should be a low priority because of the amount of work likely necessary to make it work.

OlehKSS commented 6 years ago

Do you think this can be closed, since in pull request #25 support for multiple views and hemi='split' were added?

larsoner commented 6 years ago

Let's wait until the views actually works. IPyvolume needs some camera fix, right?

OlehKSS commented 6 years ago

Yes, there is a bug https://github.com/maartenbreddels/ipyvolume/issues/156

larsoner commented 6 years ago

Is it worth you looking into it to see if you can fix it?

OlehKSS commented 6 years ago

I have no idea how hard can it be. As far as I understand, the bug appeared due to the switch to threejs camera. I will ask whether anyone working on it right now.