search

mne-tools / mne-gsoc2018-3d

Sandbox for GSoC 2018 3D Viz
BSD 3-Clause "New" or "Revised" License
9 stars 4 forks source link

Changed the auto colormap #39

Open Sentient07 opened 5 years ago

Sentient07 commented 5 years ago

Addresses #38 . @larsoner should I add any tests to confirm? I don't see a regular test suite here, how to verify this patch?(It works for me locally)

Sentient07 commented 5 years ago

From the travis config file, I could see we're just attempting an import of the package and using pytest to confirm if the library is building as desired. Would writing targetted tests help in this case?

agramfort commented 5 years ago

see how it's done in pysurfer

Sentient07 commented 5 years ago

@agramfort @larsoner I have made the changes in accordance with PySurfer. It seems to be fine when I try an example.

I am not sure if this code has to be in add_data or the _calculate_lut method inside the colormap.py.