search

mne-tools / mne-gsoc2018-3d

Sandbox for GSoC 2018 3D Viz
BSD 3-Clause "New" or "Revised" License
9 stars 4 forks source link

Fixes #3. Empty module for the project. #5

Closed OlehKSS closed 6 years ago

OlehKSS commented 6 years ago

I have a problem with package naming, import mne-gsoc2018-3d is not valid due to the hyphens. This problem can by solved either by using __import__ function or by changing package name to something without hyphens, e. g. mnegsoc20183d or mne3d. Should I rename package?

OlehKSS commented 6 years ago

@larsoner , @agramfort should I share links to the opened pull requests in Gitter or just leaving it here is enough?

agramfort commented 6 years ago

the more you communicate the better

OlehKSS commented 6 years ago

@larsoner I have updated PR code according to your suggestions.

choldgraf commented 6 years ago

@agramfort can you add me as an admin on this repo?

larsoner commented 6 years ago

done

larsoner commented 6 years ago

Next steps would be:

  1. create mne_g3d folder
  2. add mne_g3d/__init__.py (can be blank)
  3. add mne_g3d/viz.py (can be blank)

Once you want to add code, put it in viz.py. Import any functions / classes you want to be publicly visible in __init__.py with from .viz import whatever.

choldgraf commented 6 years ago

woot! first PR for the GSOC is merged 🎉 🎉 🎉