search

mne-tools / mne-hfo

Estimate/compute high-frequency oscillations (HFOs) from iEEG data that are BIDS and MNE compatible using a scikit-learn-style API.
http://mne.tools/mne-hfo/
BSD 3-Clause "New" or "Revised" License
13 stars 16 forks source link

[MRG] Compare scorers #21

Closed pmyers16 closed 3 years ago

pmyers16 commented 3 years ago

PR Description

Introduces a compare module that can find the agreement between two detectors.

Closes: https://github.com/adam2392/mne-hfo/issues/22

Merge checklist

Maintainer, please confirm the following before merging:

codecov[bot] commented 3 years ago

Codecov Report

Merging #21 (472c437) into master (eb97290) will increase coverage by 1.17%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
+ Coverage   69.79%   70.96%   +1.17%     
==========================================
  Files          12       13       +1     
  Lines        1013     1054      +41     
==========================================
+ Hits          707      748      +41     
  Misses        306      306
Impacted Files Coverage Δ
mne_hfo/__init__.py 100.00% <100.00%> (ø)
mne_hfo/compare.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eb97290...472c437. Read the comment docs.

pmyers16 commented 3 years ago

Can you include tests to cover lines in mne_hfo/compare.py?

Should be fixed

pmyers16 commented 3 years ago

Just rename the functions and re-update the jupyter notebook.

FYI: for future things that don't require the "real" data, you can just add a "python file example".

Okay, changes made.