mne-tools / mne-hfo

Estimate/compute high-frequency oscillations (HFOs) from iEEG data that are BIDS and MNE compatible using a scikit-learn-style API.
http://mne.tools/mne-hfo/
BSD 3-Clause "New" or "Revised" License
13 stars 16 forks source link

Discover if Hilbert Detector's sparse detections is by design or flaw #32

Open pmyers16 opened 3 years ago

pmyers16 commented 3 years ago

Describe the bug

The Hilbert Detector picks up way less HFO events than either of the RMS or LineLength Detectors. We need to figure out if this is by design or if it is a code bug before we use this in a study.

Steps to reproduce

Run the unit tests, pytest ./tests/test_detect.py::test_detect_hfo_hilbert and see that it misses detections

Expected results

We do not currently know what the expected output should be, so this might be right

Actual results

The first event is missed.