mne-tools / mne-hfo

Estimate/compute high-frequency oscillations (HFOs) from iEEG data that are BIDS and MNE compatible using a scikit-learn-style API.

http://mne.tools/mne-hfo/

BSD 3-Clause "New" or "Revised" License

13 stars 16 forks source link

[MRG] Adding release for 0.2. #44

Closed adam2392 closed 3 years ago

adam2392 commented 3 years ago

PR Description

Release for 0.2.

Merge checklist

Maintainer, please confirm the following before merging:

[ ] All comments resolved
[ ] This is not your own PR
[ ] All CIs are happy
[ ] PR title starts with [MRG]
[ ] whats_new.rst is updated
[ ] PR description includes phrase "closes <#issue-number>"

codecov-commenter commented 3 years ago

Codecov Report

Merging #44 (d83c301) into master (a5f6c38) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head d83c301 differs from pull request most recent head 6272c83. Consider uploading reports for the commit 6272c83 to get more accurate results

@@           Coverage Diff           @@
##           master      #44   +/-   ##
=======================================
  Coverage   72.34%   72.34%           
=======================================
  Files          13       13           
  Lines        1150     1150           
=======================================
  Hits          832      832           
  Misses        318      318

Impacted Files	Coverage Δ
mne_hfo/__init__.py	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a5f6c38...6272c83. Read the comment docs.

adam2392 commented 3 years ago

@larsoner Hi! I am trying to make a new release now following: https://github.com/mne-tools/mne-bids/wiki/How-to-make-a-release#prepare-stable-docs

I'm at the step of pushing a release to pypi. It specifies I need admin access. Is this something I need for my pypi account, or should I just use my personal one adam2392?

larsoner commented 3 years ago

You are listed as the only maintainer on https://pypi.org/project/mne-hfo/, so it seems like it should work.

If you set up 2-factor authentication the instructions are different. For example I have entries like this in my ~/.pypirc:

[mne]
  repository = https://upload.pypi.org/legacy/
  username = __token__
  password = <redacted>

where the <redacted> password was a token generated on PyPi as a one-time-shown token generated in the "API tokens" section of my PyPi profile that allows me to upload to MNE. And when I upload MNE I do:

twine upload dist/* --repository mne --verbose

I do not appear to have admin permissions on mne-hfo so I can't tweak anything there. Usually you want at least two people to have access to settings and such, feel free to add me (Eric89GXL) as an admin/whatever on PyPi.

adam2392 commented 3 years ago

Oh okay! If I can do everything using my own account, then that's great. I just updated and did the official v0.2 release now which brings things fully under the mne umbrella.

I also added you as a maintainer on pypi since that seemed easy enough. Thanks for the help!