mne-tools / mne-installers

Installers for MNE-Python.
BSD 3-Clause "New" or "Revised" License
9 stars 8 forks source link

Test M1 installers before making a public release #128

Closed hoechenberger closed 2 years ago

hoechenberger commented 2 years ago

https://github.com/mne-tools/mne-installers/releases/tag/untagged-41d19bf875fbbe3e2fab

hoechenberger commented 2 years ago

The installer title says it's version 1.0.3_0, but it should be 1.0.3_1 🤔

Screen Shot 2022-06-03 at 12 53 14

Edit: This is being addressed in #129

hoechenberger commented 2 years ago

Looking good so far:

❯ mne sys_info
Platform:         macOS-12.4-arm64-arm-64bit
Python:           3.10.4 | packaged by conda-forge | (main, Mar 24 2022, 17:42:03) [Clang 12.0.1 ]
Executable:       /Applications/MNE-Python/.mne-python/bin/python3.10
CPU:              arm: 8 cores
Memory:           16.0 GB

mne:              1.0.3
numpy:            1.21.6 {blas=NO_ATLAS_INFO, lapack=lapack}
scipy:            1.8.1
matplotlib:       3.5.2 {backend=MacOSX}

sklearn:          1.1.1
numba:            0.55.1
nibabel:          3.2.2
nilearn:          0.9.1
dipy:             1.5.0
cupy:             Not found
pandas:           1.4.2
pyvista:          0.34.0 {OpenGL 4.1 Metal - 76.3 via Apple M1}
pyvistaqt:        0.9.0
ipyvtklink:       0.2.2
vtk:              9.1.0
PyQt5:            5.15.4
ipympl:           0.9.1
pooch:            v1.6.0

mne_bids:         0.10
mne_nirs:         0.2.1
mne_features:     0.2
mne_qt_browser:   0.3.1
mne_connectivity: 0.3
hoechenberger commented 2 years ago

Spyder is working too

Screen Shot 2022-06-03 at 13 11 37
hoechenberger commented 2 years ago

3D viz works:

Screen Shot 2022-06-03 at 13 13 59
larsoner commented 2 years ago

Awesome, sounds like we're good to go, then, right?

hoechenberger commented 2 years ago

@larsoner We still need #129 or at least the part of it that bumps the build number to 1.0.3_1

Then force-delete the 1.0.3-post1 tag I created

Then make a new draft release again

and then we can publish it :)

hoechenberger commented 2 years ago

@larsoner Updated installers:

https://github.com/mne-tools/mne-installers/releases/tag/untagged-9abf6bfabc91dd37b429

We must not forget to test the Intel installers on Apple Silicon too

Feel free to publish this release if you're happy

hoechenberger commented 2 years ago

As per discussion on Discord, we're holding off the new release until we have MNE 1.1, to not compromise the "wow" effect of the new native builds :) so the idea is to announce 1.1 together with the M1 builds.

larsoner commented 2 years ago

I think we've tested these so I'll close. I'll cut a prerelease and we should test on every platform anyway