search

mne-tools / mne-installers

Installers for MNE-Python.
BSD 3-Clause "New" or "Revised" License
9 stars 8 forks source link

BUG: Add tests for setuptools_scm versions, fix mne-qt-browser #188

Closed larsoner closed 1 year ago

larsoner commented 1 year ago

To help check https://github.com/mne-tools/mne-qt-browser/issues/165

Eventually we could probably assert actual version numbers based on our pinning file and such. But for now this is good enough I think

Should fail until https://github.com/conda-forge/mne-qt-browser-feedstock/pull/24 is in and CDNs update

hoechenberger commented 1 year ago

I don't understand why we'd need this – shouldn't dependency resolution fail if we cannot get the package version that we requested in the recipe? Or has this to do with setuptools-scm?

Edit: Ok, I read up on the linked issue. I'm okay with having this here as a temporary check until we start testing for the actual version numbers we put in the recipe, like you suggested

larsoner commented 1 year ago

I'm okay with having this here as a temporary check until we start testing for the actual version numbers we put in the recipe, like you suggested

Might as well be permanent -- conda's package version numbers are not guaranteed to match the actual module.__version__, so we might as well check the setuptools_scm packages that we have to make sure that they do.

larsoner commented 1 year ago

Will merge and cut a 1.4.0_1 release since mne-qt-browser Epochs browsing is broken on 1.4.0_0