mne-tools / mne-installers

Installers for MNE-Python.
BSD 3-Clause "New" or "Revised" License
9 stars 8 forks source link

Add pyxdf #193

Closed cbrnr closed 1 year ago

cbrnr commented 1 year ago

Fixes #192.

cbrnr commented 1 year ago

Is this the correct way to add a new dep? Should I upgrade outdated packages here as well?

larsoner commented 1 year ago

You will need to upgrade the out of date ones then cross your fingers that the resolvers are happy. If they're not we have to isolate the problem and add an out-of-date exception. It's a bit tedious but it makes sure we're as up to date as possible

cbrnr commented 1 year ago

"Hotfix for NSIS" fails, any ideas?

larsoner commented 1 year ago

Looking at

They released a new version of nsis 2 months ago, maybe we need to pin to build _1 instead of allowing _2. Another possibility I thought might be menuinst but we already pin that one.

cbrnr commented 1 year ago

The "NSIS Hotfix" job consists of this line (which will only run on Windows):

mamba install nsis=3.01 conda=4.12a

We're already pinning nsis=3.01. Do you mean that we should try using the latest version? I don't know what that hotfix does, why is it pinning these two packages in the first place?

larsoner commented 1 year ago

@jaimergp it looks like our "hotfix for nsis" mamba install nsis=3.01 conda=4.12a has started to fail, see this log. Any ideas? Maybe we need to pin another package when doing this like conda? The conlist thing makes me think that maybe it's a conda list and min_items no longer exists on the newer conda version...?

jaimergp commented 1 year ago

I think it must be the new pydantic. Pin it to pydantic <2.0a0.

cbrnr commented 1 year ago

Apparently mamba install pydantic<2.0.0a1 doesn't work (sorry, I don't use mamba/conda)...

larsoner commented 1 year ago

I think that might be a standard BASH issue with <, I'll push quotes to see if it helps

cbrnr commented 1 year ago

I think that might be a standard BASH issue with <, I'll push quotes to see if it helps

Ah, of course! Good catch! It doesn't solve the original problem though 😢.

hoechenberger commented 1 year ago

Oh no, what a pain :(

cbrnr commented 1 year ago

Thanks @larsoner!