search

mne-tools / mne-installers

Installers for MNE-Python.
BSD 3-Clause "New" or "Revised" License
8 stars 8 forks source link

[pre-commit.ci] pre-commit autoupdate #287

Closed pre-commit-ci[bot] closed 1 month ago

pre-commit-ci[bot] commented 2 months ago

updates:

larsoner commented 1 month ago

@jaimergp we are now out of nowhere getting a fishy error on our Windows installers that you might have some idea about given your knowledge of the constructor stack (and might soon hit in your stack perhaps?).

After running our installers in the Test CI step (after running the Build-created installer), one of the checks we have is that we call:

mne sys_info

All this is is a scripts entry for MNE-Python. We now are getting this weird error:

...
Checking Python location
/c/Users/runneradmin/mne-python/1.7.1_0/python
Python 3.12.4

Running MNE's sys_info
/c/Users/runneradmin/mne-python/1.7.1_0/Scripts/mne: line 2: C:/Users/runneradmin/mne-python/1.7.1_0/bin/python: No such file or directory

You can see the output above that which python is now /c/Users/runneradmin/mne-python/1.7.1_0/python but the mne command points to C:/Users/runneradmin/mne-python/1.7.1_0/bin/python. But:

  1. Things were fine/green last week (~8 days ago)
  2. The mne-python recipe that has this entry point hasn't been updated in 3 weeks
  3. Things are still fine on macOS and Linux, saying things like: 
    Checking Python location
/home/runner/mne-python/1.7.1_0/bin/python

This makes me wonder if something is wrong with the constructor stack. Unfortunately we purge the logs so I can't look at what was installed that worked a week ago. I tried rolling back conda to 24.5.0 because 24.7.1 did come out yesterday but it didn't seem to help.

larsoner commented 1 month ago

@jaimergp are command-line invocations currently working on Windows (CIs) for napari with the latest constructor stack? Ours are broken for some reason, but I don't think we do anything special

jaimergp commented 1 month ago

Maybe some update in the GHA base image? cygpath or something?

larsoner commented 1 month ago

Wow, took me a loooooooong time to figure out but this was the key after installing the new broken installer locally:

$ conda package -w /c/Users/tester/mne-python/1.7.1_00/Scripts/mne
C:/Users/tester/mne-python/1.7.1_00/Scripts/mne     conda-forge/noarch::mne-nirs-0.7.0-pyhd8ed1ab_0

we errantly added a mne entry point for mne-nirs that was wrong. Locally removing mne-nirs and reinstalling mne-base fixes things :facepalm: