search

mne-tools / mne-nirs

Process Near-Infrared Spectroscopy Data in MNE
https://mne.tools/mne-nirs/
BSD 3-Clause "New" or "Revised" License
79 stars 35 forks source link

Dataset downloading is broken until MNE-python is fixed #386

Closed rob-luke closed 2 years ago

rob-luke commented 2 years ago

Describe the bug

Apparently this package won't load and complains about dataset downloaded not working.

Steps to reproduce

Haven't reproduced myself but I expect it's due to recent changes in how MNE downloads datasets. It's been changed to use poooch by @adam2392

Additional information

I will wait for https://github.com/mne-tools/mne-python/pull/9763 before I can fix this

drammock commented 2 years ago

@rob-luke can you say more about what's broken? What did you try to do and what happened?

rob-luke commented 2 years ago

I haven't tried myself yet. But I just received an email from a user reporting the above. And it makes sense given I use internal MNE functions and that's been modified recently.

Here's the report I got... image Kicking off a CI should confirm if this issue exists

drammock commented 2 years ago

ah, OK. yeah, _download() was removed yesterday. Lemme see if I can quickly bang out a fix for you (I have 30 minutes before I go on leave for a week :)

rob-luke commented 2 years ago

That would be very kind of you!

adam2392 commented 2 years ago

I'm going to finish off https://github.com/mne-tools/mne-python/pull/9763 tonight, which should allow you to refactor your fetching code to follow that framework.

rob-luke commented 2 years ago

Thanks @adam2392 and @drammock for keeping me posted. The new functionality is very cool and I look forward to using it. Once its up and running I have a few more open datasets to add.

rob-luke commented 2 years ago

Cross referencing #388