mne-tools / mne-nirs

Process Near-Infrared Spectroscopy Data in MNE
https://mne.tools/mne-nirs/
BSD 3-Clause "New" or "Revised" License
84 stars 35 forks source link

hackish workaround for changes to downloading #388

Closed drammock closed 3 years ago

drammock commented 3 years ago

@rob-luke this is not great and should really wait for https://github.com/mne-tools/mne-python/pull/9763 but maybe this is enough of a stopgap for now?

rob-luke commented 3 years ago

Thanks @drammock!! Stopgap is good enough for me for now. And we can follow up when the MNE-Python PR is merged. Thanks for doing this!

codecov-commenter commented 3 years ago

Codecov Report

Merging #388 (9b2e7b7) into main (2deb731) will increase coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #388      +/-   ##
==========================================
+ Coverage   93.43%   93.46%   +0.02%     
==========================================
  Files          56       56              
  Lines        2179     2189      +10     
  Branches      288      288              
==========================================
+ Hits         2036     2046      +10     
  Misses         86       86              
  Partials       57       57              
Impacted Files Coverage Δ
...rs/datasets/fnirs_motor_group/fnirs_motor_group.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2deb731...9b2e7b7. Read the comment docs.

rob-luke commented 3 years ago

Thanks @drammock