Closed larsoner closed 2 years ago
Merging #455 (0b260a6) into main (4bdf566) will increase coverage by
0.07%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## main #455 +/- ##
==========================================
+ Coverage 93.25% 93.33% +0.07%
==========================================
Files 65 65
Lines 2670 2670
Branches 340 340
==========================================
+ Hits 2490 2492 +2
+ Misses 121 120 -1
+ Partials 59 58 -1
Impacted Files | Coverage Δ | |
---|---|---|
mne_nirs/visualisation/_plot_3d_montage.py | 98.97% <0.00%> (+2.04%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 4bdf566...0b260a6. Read the comment docs.
0.9 changed the way that annotation names were treated and validated etc. So code that works with 0.8 doesn't necessarily work with 0.9+.
So I think we should support 0.9 and above only.
Seems the CIs aren't happy though :(
Failures were just not having the fOLD files, fixed. I'll go ahead and merge. We should backport this and release a 0.2.1. I'll actually wait to do that until the doc buliding is fixed, hopefully tomorrow! Then we can see deployment of 0.2.1 docs and 0.3.dev0 docs, hopefully.
@rob-luke 0.9 was released about a month ago (Jan 28). Should we require 0.8 instead?
Closes #454