Closed rob-luke closed 2 years ago
Merging #468 (aa750f1) into main (eec00b9) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #468 +/- ##
=======================================
Coverage 94.08% 94.08%
=======================================
Files 65 65
Lines 2673 2673
Branches 396 396
=======================================
Hits 2515 2515
Misses 101 101
Partials 57 57
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update eec00b9...aa750f1. Read the comment docs.
This pull request introduces 2 alerts when merging 850f9f4aceb48adb3eebfffdffa6f9ce20bfdaac into 63d56e0510aea8de11d78aa4264c8375e3f6f2db - view on LGTM.com
new alerts:
@samuelpowell could you (or someone else at Gowerlab) please review this PR. You can view the rendered document here. I have also given you access to the branch so you can edit the document directly in the web interface.
If you have specific text changes you want then please edit the branch directly, or use the "add a suggestion" option in the code review (Files Changed
tab). And we can expand the code too if there are some additional functionality that users often request.
And we should have a few more tutorials on analysis, but we need more extensive data for that.
@rob-luke this is splendid thank you, we will review this week.
great @samuelpowell, and feel free to edit as much as you wish, the more information the better. The formatting stuff can be fiddly, feel free to just get the text in there that you want and I can help with making sure it compiles without errors etc.
@rob-luke just realised it’s a three day week owing to bank holidays so it will be next week before we can review, hope that’s alright.
@nidadu could you add your suggestions inline on the web interface and I will go through and do a final clean and review?
your suggestions inline on the web interface
You both have write access for the branch. So it may be more efficient to push your changes directly to the branch. Or do it via suggestions.
Thanks @nidadu I'll merge whatever I'm qualified to merge, and make my own changes. @rob-luke we will ping you with any remaining queries once I've gone through this.
Thanks @nidadu
The continuous integration ran so long ago that the page render has now been deleted. I'll kick the CI to make a fresh page render. Feel free to add reference articles or other useful links too. And we can always incrementally improve this page after it's merged.
@rob-luke I'm happy with this. Please squash my untidy commits or ping me if you'd like me to do so!
This is great, thanks @samuelpowell and @nidadu. Moving forward, feel free to propose updates and changes if you have further ideas or get feedback from users.
Reference issue
Closes #419
What does this implement/fix?
Work in progress
Additional information
Work in progress