Closed rob-luke closed 2 years ago
Merging #481 (a84ee4d) into main (92a17b3) will increase coverage by
3.31%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #481 +/- ##
==========================================
+ Coverage 92.64% 95.96% +3.31%
==========================================
Files 65 65
Lines 2653 2676 +23
Branches 391 397 +6
==========================================
+ Hits 2458 2568 +110
+ Misses 139 51 -88
- Partials 56 57 +1
Impacted Files | Coverage Δ | |
---|---|---|
mne_nirs/tests/test_examples.py | 81.25% <100.00%> (+0.60%) |
:arrow_up: |
mne_nirs/visualisation/tests/test_visualisation.py | 100.00% <100.00%> (ø) |
|
mne_nirs/preprocessing/_mayer.py | 98.00% <0.00%> (+2.00%) |
:arrow_up: |
mne_nirs/visualisation/_plot_3d_montage.py | 98.03% <0.00%> (+84.31%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
/opt/hostedtoolcache/Python/3.10.6/x64/lib/python3.10/site-packages/mne/viz/backends/_pyvista.py:1097: in _close_3d_figure
del _ALL_PLOTTERS[plotter._id_name]
E KeyError: '0x7f75563cb370-0'
this is on the failing (dev)
build but this line has been fixed upstream
FYI I added branch protection rules for main
and enabled auto-squash-and-merge so now there is a button you can click to "squash and merge when green" @rob-luke
This is amazing! Thanks @larsoner
@larsoner do you know how to fix the errors being thrown in the github actions here? It seems to be related to https://github.com/mne-tools/mne-python/pull/11129, but I don't want to require MNE main. Thanks