mne-tools / mne-nirs

Process Near-Infrared Spectroscopy Data in MNE
https://mne.tools/mne-nirs/
BSD 3-Clause "New" or "Revised" License
79 stars 35 forks source link

BUG: Minor fix and version bump #491

Closed larsoner closed 1 year ago

larsoner commented 1 year ago

@rob-luke okay to merge and cut a release? We'll want this for MNE 1.2 release

larsoner commented 1 year ago

cc @drammock this is another repo that needed it

larsoner commented 1 year ago

@rob-luke the failure is due to the deprecated plot_glm_topo, okay to remove it and call this version 1.0.0?

codecov[bot] commented 1 year ago

Codecov Report

Merging #491 (50edc77) into main (437e85c) will decrease coverage by 0.56%. The diff coverage is 81.63%.

@@            Coverage Diff             @@
##             main     #491      +/-   ##
==========================================
- Coverage   95.88%   95.32%   -0.57%     
==========================================
  Files          68       68              
  Lines        2724     2715       -9     
  Branches      403      395       -8     
==========================================
- Hits         2612     2588      -24     
- Misses         54       64      +10     
- Partials       58       63       +5     
Impacted Files Coverage Δ
mne_nirs/conftest.py 100.00% <ø> (ø)
mne_nirs/statistics/__init__.py 100.00% <ø> (ø)
mne_nirs/visualisation/_plot_3d_montage.py 98.03% <50.00%> (ø)
mne_nirs/visualisation/_plot_GLM_topo.py 86.57% <74.19%> (-9.80%) :arrow_down:
mne_nirs/_version.py 100.00% <100.00%> (ø)
mne_nirs/simulation/_simulation.py 100.00% <100.00%> (ø)
mne_nirs/statistics/_glm_level_first.py 87.79% <100.00%> (-0.15%) :arrow_down:
mne_nirs/tests/test_examples.py 80.64% <100.00%> (-0.61%) :arrow_down:
mne_nirs/utils/tests/test_io.py 100.00% <100.00%> (ø)
mne_nirs/visualisation/__init__.py 100.00% <100.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

lgtm-com[bot] commented 1 year ago

This pull request introduces 1 alert when merging 078c12b800b495528c95accc49a6b3b502b6f59a into 437e85c202752404cc4469b0b1e61db383ad1e8c - view on LGTM.com

new alerts:

larsoner commented 1 year ago

@rob-luke okay to merge and release 0.4.0? If so, are you up for making the release?

rob-luke commented 1 year ago

Thanks @larsoner this is great. I will make a release in next few days, but if you have time to cut a release before me that's awesome. I definitely want to make a release before Sunday (fNIRS conference MNE tutorial).