mne-tools / mne-nirs

Process Near-Infrared Spectroscopy Data in MNE
https://mne.tools/mne-nirs/
BSD 3-Clause "New" or "Revised" License
79 stars 35 forks source link

MAINT: Update dependencies and revitalize the CI pipeline #507

Closed florin-pop closed 1 year ago

florin-pop commented 1 year ago

This PR fixes https://github.com/mne-tools/mne-nirs/issues/506 by introducing the following changes:

These fixes were mostly adaptations of changes introduced by @larsoner in https://github.com/mne-tools/mne-python/


Contributed with ❤️ by AE Studio

codecov[bot] commented 1 year ago

Codecov Report

Merging #507 (3f0384a) into main (ad218df) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #507   +/-   ##
=======================================
  Coverage   95.36%   95.36%           
=======================================
  Files          69       69           
  Lines        2781     2781           
  Branches      397      397           
=======================================
  Hits         2652     2652           
  Misses         65       65           
  Partials       64       64           
Impacted Files Coverage Δ
mne_nirs/statistics/_glm_level_first.py 87.79% <ø> (ø)
rob-luke commented 1 year ago

Thanks @florin-pop it looks good to me. I also looked through the rendered docs and they were correct (including the 3d renders).

Could you please revert the change you wanted to revert and then ping Eric to merge.

rob-luke commented 1 year ago

Could you please revert the change you wanted to revert and then ping Eric to merge.

I remembered I can revert the change myself ;) So we don't need to bug Eric now and I'll merge when all green

rob-luke commented 1 year ago

This is absolutely super! Thanks @florin-pop