search

mne-tools / mne-nirs

Process Near-Infrared Spectroscopy Data in MNE
https://mne.tools/mne-nirs/
BSD 3-Clause "New" or "Revised" License
79 stars 35 forks source link

Extend SNIRF support to v1.1 #509

Closed florin-pop closed 1 year ago

florin-pop commented 1 year ago

Fixes https://github.com/mne-tools/mne-nirs/issues/505

Writing data into the SNIRF format will use v1.1 of this spec by default.

The diff between v1.0 and v1.1: https://github.com/fNIRS/snirf/compare/v1.1..v1.0#diff-a6c853dca5f1a8eb3e37e0de75889250190b68f3597e91f33489a05874aa49c4

Contributed with ❤️ by AE Studio

codecov[bot] commented 1 year ago

Codecov Report

Merging #509 (140d275) into main (bcea89b) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #509   +/-   ##
=======================================
  Coverage   95.36%   95.36%           
=======================================
  Files          69       69           
  Lines        2781     2781           
  Branches      397      397           
=======================================
  Hits         2652     2652           
  Misses         65       65           
  Partials       64       64
Impacted Files Coverage Δ
mne_nirs/io/snirf/tests/test_snirf.py 97.81% <ø> (ø)
mne_nirs/io/snirf/_snirf.py 95.80% <100.00%> (ø)
rob-luke commented 1 year ago

Well that went smoother than expected. Thanks @florin-pop

Please add a note to the https://github.com/mne-tools/mne-nirs/blob/main/doc/changelog.rst. Then I will merge once CI is green 🚀

rob-luke commented 1 year ago

Awesome, thanks @florin-pop