search

mne-tools / mne-nirs

Process Near-Infrared Spectroscopy Data in MNE
https://mne.tools/mne-nirs/
BSD 3-Clause "New" or "Revised" License
79 stars 35 forks source link

Fix dependency list and docs repo link #518

Closed girishmm closed 1 year ago

girishmm commented 1 year ago

Missing seaborn dependency raises ModuleNotFoundError. 

>>> import mne_nirs
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/opt/homebrew/Caskroom/miniconda/base/lib/python3.10/site-packages/mne_nirs/__init__.py", line 10, in <module>
    from . import statistics
  File "/opt/homebrew/Caskroom/miniconda/base/lib/python3.10/site-packages/mne_nirs/statistics/__init__.py", line 7, in <module>
    from ._glm_level_first import (RegressionResults, ContrastResults,
  File "/opt/homebrew/Caskroom/miniconda/base/lib/python3.10/site-packages/mne_nirs/statistics/_glm_level_first.py", line 28, in <module>
    from ..visualisation._plot_GLM_topo import _plot_glm_topo,\
  File "/opt/homebrew/Caskroom/miniconda/base/lib/python3.10/site-packages/mne_nirs/visualisation/__init__.py", line 7, in <module>
    from ._plot_quality_metrics import plot_timechannel_quality_metric
  File "/opt/homebrew/Caskroom/miniconda/base/lib/python3.10/site-packages/mne_nirs/visualisation/_plot_quality_metrics.py", line 5, in <module>
    import seaborn as sns
ModuleNotFoundError: No module named 'seaborn'

Added this to dependency list in setup.py. This fixes #517.

The GitHub link in mne-nirs docs points to the mne-python repo as mentioned in https://github.com/mne-tools/mne-nirs/issues/517#issuecomment-1664439889. Changed the repo link to mne-nirs as it more appropriate.

larsoner commented 1 year ago

Argh other deprecations are making CIs unhappy... I'll make a quick PR then merge main and it should get things green here 👍

larsoner commented 1 year ago

Marking for merge when green, thanks in advance @girishmm !

codecov[bot] commented 1 year ago

Codecov Report

Merging #518 (eff279a) into main (6baf34c) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #518   +/-   ##
=======================================
  Coverage   95.28%   95.28%           
=======================================
  Files          69       69           
  Lines        2865     2865           
  Branches      412      412           
=======================================
  Hits         2730     2730           
  Misses         65       65           
  Partials       70       70