mne-tools / mne-nirs

Process Near-Infrared Spectroscopy Data in MNE
https://mne.tools/mne-nirs/
BSD 3-Clause "New" or "Revised" License
79 stars 35 forks source link

fix: change ci param to errorbar in sns-catplot #524

Closed Busato closed 10 months ago

Busato commented 10 months ago

What does this implement/fix?

Two tests were failing because of a deprecation of the ci parameter in sns.catplot function.

image

They were changed to errorbar instead that do the same thing when using None (both of the were using it)

Contributed with ❤️ by AE Studio

codecov[bot] commented 10 months ago

Codecov Report

Merging #524 (91b407f) into main (047a27a) will not change coverage. Report is 1 commits behind head on main. The diff coverage is n/a.

:exclamation: Current head 91b407f differs from pull request most recent head acbc32f. Consider uploading reports for the commit acbc32f to get more accurate results

@@           Coverage Diff           @@
##             main     #524   +/-   ##
=======================================
  Coverage   95.22%   95.22%           
=======================================
  Files          69       69           
  Lines        2868     2868           
  Branches      412      412           
=======================================
  Hits         2731     2731           
  Misses         66       66           
  Partials       71       71           
larsoner commented 10 months ago

CI failures appear unrelated, let me fix those in a separate PR then merge main into this branch, then should be good to go. Thanks in advance @Busato !

larsoner commented 10 months ago

You can now also remove this line that I added https://github.com/mne-tools/mne-nirs/pull/525/files#diff-15c86dcddb07192eeb2d84db2a5dfca48e3837471adbbd9b3e05425b44fce485R49 if you want to make sure it has been fixed everywhere

rob-luke commented 10 months ago

Thanks @Busato 🎉