Closed aaronjnewman closed 4 months ago
If changing first_name to his_id is acceptable, I can do a PR for that. But I worry that this might mess up other functions
I suspect first_name
was never the correct place for this. If it's a subject actual name (usually identifiable) there should be first_name
and last_name
generally. If it's an identifier (usually anonymized) it should be in his_id
.
Describe the bug
I have SNIRF files collected using NIRx Aurora that I import with
mne.io.read_raw_snirf()
and then write to BIDS with MNE-BIDS'write_raw_bids()
function.I then import my raw BIDS data in another script to do preprocessing. When I go to write the preprocessed data with
write_raw_snirf
I get the error:I can fix the error by modifying the _snirf.py file to look for
his_id
rather thanfirst_name
. However, I'm not sure if that is a robust fix for the codebase. It does strike me as odd that thefirst_name
field is assumed to store the subject ID. If changingfirst_name
tohis_id
is acceptable, I can do a PR for that. But I worry that this might mess up other functions.