mne-tools / mne-python

MNE: Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python
https://mne.tools
BSD 3-Clause "New" or "Revised" License
2.7k stars 1.31k forks source link

BaseRaw + io module #1003

Closed agramfort closed 10 years ago

agramfort commented 10 years ago

I'd like to summarize what I feel needs to be done on the BaseRaw class + io module. Here are the few steps I would take

then introduce a BaseRaw class in mne/io/base.py , define the interface and update the base class in every object in the Raw family

do I forget something?

any volunteer? :)

dengemann commented 10 years ago

@agramfort the problem I see is that using a proper ABC class won't allow for inheritance. All methods expected by the API will be needed to be implemented by the advanced user, if only wrapping super calls to the base class. I'm not sure this is really what we want.

agramfort commented 10 years ago

abstract methods should be only the methods required by subclasses.

the other methods are inherited

agramfort commented 10 years ago

duplicate