Open hoechenberger opened 2 years ago
In the coreg app, we have a standalone
parameter which control that. We could add the same to Brain
? But adding yet another one to plot_alignment
might be too much.
I was more thinking of something like block
, which we have for our matplotlib plotting functions too
I do not mind changing the name if it does the same thing.
standalone
is fine for Coreg, I think. Just for the others – if we add this functionality, I think it should be block
. :)
Why keeping coreg as the only exception?
Why keeping coreg as the only exception?
To avoid discussions about backward-compat ;) I don't care enough about this one to discuss 😅😅😅😅😅
backward-compat... Honestly, the new version of coreg has not been around for so long, I don't know if people had really the time to play around with the standalone
parameter. I still think the change is worth it for consistency (just a rename in practice). But I understand your point.
Ah ok! Thought we'd always had this param. In that case – let's block it 😁👌
plot_alignment
is still open.
The alignment and the
Brain
plots are both used in interactive exploration and in non-interactive scripts.A common annoying issue that I and other users regularly run into is that we write a short script that displays the sensor alignment or a
SourceEstimate
, run it (e.g. via theRun
button in VS Code), the window pops up – and immediately disappears. So one then needs to run the script again -- this time, withpython -i
or after inserting some blocking call likeinput()
.It would be great if there was an easier way to ensure a blocking behavior.
cc @GuillaumeFavelier