Closed Dod12 closed 2 years ago
Hello! š Thanks for opening your first issue here! ā¤ļø We will try to get back to you soon. š“š½āāļø
@Dod12 agreed this seems like a bug, would you be up for making a PR to fix it? The minimal example above is already a good start for a unit test!
@larsoner Sure, I'll work on the tests over the weekend.
Describe the bug
The
mne.decoding.TimeFrequency
transformer modifies constructor arguments, violating scikit-learn guidance on estimators. This leads to a cloning error when using the function in a pipeline. I was able to resolve the issue by moving the_check_tfr_param
call to the transform method, in line with other checks performed at that time. See the changes made to mne.decoding.time_frequency.pySteps to reproduce
Expected results
Successful completion of cross validation.
Actual results
Additional information