search

mne-tools / mne-python

MNE: Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python
https://mne.tools
BSD 3-Clause "New" or "Revised" License
2.72k stars 1.32k forks source link

BrainVision IO -- Comment section is partially hardcoded and may lead to problems #12134

Open sappelhoff opened 1 year ago

sappelhoff commented 1 year ago

For example here we assume that if a "Channels" section is present in the "Comment" section, it always has a certain number of "columns":

https://github.com/mne-tools/mne-python/blob/4518a1a918051542ab7360ff63c529121a499417/mne/io/brainvision/brainvision.py#L674C24-L674C30

But this is not necessarily the case, see:

https://mne.discourse.group/t/indexerror-in-brainvision-py/7187

I think we should amend our code to do a quick parsing of the number of columns in the "Channels" section if it is present.

cbrnr commented 1 year ago

What does the standard say?

sappelhoff commented 1 year ago

The standard says:

image

source: https://www.brainproducts.com/support-resources/brainvision-core-data-format-1-0/ (and the linked PDF there)

cbrnr commented 1 year ago

Ah OK then 😄!