search

mne-tools / mne-python

MNE: Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python
https://mne.tools
BSD 3-Clause "New" or "Revised" License
2.67k stars 1.31k forks source link

Replace percent format with format specifiers (f-strings) #12360

Open cbrnr opened 8 months ago

cbrnr commented 8 months ago

12358 left a bunch of strings that need to be converted from percent formatting to ideally f-strings. Ruff rule UP031 can then be enabled in pyproject.toml.

I think it would also be worth searching for " % " (or similar), because it looks like Ruff doesn't find all percent-formatted strings.

Aditya3425-Fst commented 7 months ago

Hii @cbrnr , I would like to be assigned to this issue. Also can you create a checklist for all the files that need to be reformatted to use f strings.

cbrnr commented 7 months ago

Great, thanks @Aditya3425-Fst! You can get a list of missing conversions by running ruff check mne --config pyproject.toml --select UP031 in the MNE root directory. Currently, there are 359 errors:

``` mne/fixes.py:102:14: UP031 Use format specifiers instead of percent format mne/fixes.py:193:21: UP031 Use format specifiers instead of percent format mne/fixes.py:268:25: UP031 Use format specifiers instead of percent format mne/fixes.py:278:25: UP031 Use format specifiers instead of percent format mne/fixes.py:291:16: UP031 Use format specifiers instead of percent format mne/forward/_compute_forward.py:664:15: UP031 Use format specifiers instead of percent format mne/forward/_lead_dots.py:72:32: UP031 Use format specifiers instead of percent format mne/forward/_lead_dots.py:77:32: UP031 Use format specifiers instead of percent format mne/forward/_make_forward.py:302:17: UP031 Use format specifiers instead of percent format mne/forward/_make_forward.py:696:21: UP031 Use format specifiers instead of percent format mne/forward/forward.py:1260:17: UP031 Use format specifiers instead of percent format mne/forward/forward.py:1270:13: UP031 Use format specifiers instead of percent format mne/forward/forward.py:1422:17: UP031 Use format specifiers instead of percent format mne/forward/forward.py:1427:17: UP031 Use format specifiers instead of percent format mne/forward/forward.py:1494:21: UP031 Use format specifiers instead of percent format mne/forward/forward.py:1516:13: UP031 Use format specifiers instead of percent format mne/inverse_sparse/mxne_inverse.py:59:13: UP031 Use format specifiers instead of percent format mne/inverse_sparse/mxne_inverse.py:815:13: UP031 Use format specifiers instead of percent format mne/inverse_sparse/mxne_inverse.py:1093:25: UP031 Use format specifiers instead of percent format mne/inverse_sparse/mxne_optim.py:246:30: UP031 Use format specifiers instead of percent format mne/inverse_sparse/mxne_optim.py:528:29: UP031 Use format specifiers instead of percent format mne/inverse_sparse/mxne_optim.py:548:18: UP031 Use format specifiers instead of percent format mne/inverse_sparse/mxne_optim.py:643:13: UP031 Use format specifiers instead of percent format mne/inverse_sparse/mxne_optim.py:1273:25: UP031 Use format specifiers instead of percent format mne/inverse_sparse/mxne_optim.py:1506:13: UP031 Use format specifiers instead of percent format mne/inverse_sparse/mxne_optim.py:1626:13: UP031 Use format specifiers instead of percent format mne/io/artemis123/artemis123.py:134:47: UP031 Use format specifiers instead of percent format mne/io/artemis123/tests/test_artemis123.py:39:30: UP031 Use format specifiers instead of percent format mne/io/artemis123/tests/test_artemis123.py:43:32: UP031 Use format specifiers instead of percent format mne/io/base.py:416:21: UP031 Use format specifiers instead of percent format mne/io/base.py:1487:30: UP031 Use format specifiers instead of percent format mne/io/base.py:1489:30: UP031 Use format specifiers instead of percent format mne/io/base.py:1492:17: UP031 Use format specifiers instead of percent format mne/io/base.py:1774:17: UP031 Use format specifiers instead of percent format mne/io/base.py:2062:13: UP031 Use format specifiers instead of percent format mne/io/base.py:2069:16: UP031 Use format specifiers instead of percent format mne/io/base.py:2127:17: UP031 Use format specifiers instead of percent format mne/io/base.py:2803:17: UP031 Use format specifiers instead of percent format mne/io/brainvision/brainvision.py:867:21: UP031 Use format specifiers instead of percent format mne/io/cnt/cnt.py:295:24: UP031 Use format specifiers instead of percent format mne/io/ctf/ctf.py:230:17: UP031 Use format specifiers instead of percent format mne/io/ctf/info.py:174:13: UP031 Use format specifiers instead of percent format mne/io/ctf/info.py:220:21: UP031 Use format specifiers instead of percent format mne/io/curry/curry.py:428:21: UP031 Use format specifiers instead of percent format mne/io/egi/egimff.py:67:28: UP031 Use format specifiers instead of percent format mne/io/egi/egimff.py:75:36: UP031 Use format specifiers instead of percent format mne/io/egi/egimff.py:106:13: UP031 Use format specifiers instead of percent format mne/io/egi/egimff.py:158:17: UP031 Use format specifiers instead of percent format mne/io/eyelink/tests/test_eyelink.py:236:18: UP031 Use format specifiers instead of percent format mne/io/eyelink/tests/test_eyelink.py:241:17: UP031 Use format specifiers instead of percent format mne/io/eyelink/tests/test_eyelink.py:248:18: UP031 Use format specifiers instead of percent format mne/io/fieldtrip/utils.py:56:17: UP031 Use format specifiers instead of percent format mne/io/fieldtrip/utils.py:177:21: UP031 Use format specifiers instead of percent format mne/io/fieldtrip/utils.py:366:28: UP031 Use format specifiers instead of percent format mne/io/kit/coreg.py:89:15: UP031 Use format specifiers instead of percent format mne/io/kit/coreg.py:166:17: UP031 Use format specifiers instead of percent format mne/io/kit/coreg.py:172:13: UP031 Use format specifiers instead of percent format mne/io/kit/kit.py:538:21: UP031 Use format specifiers instead of percent format mne/io/nirx/nirx.py:104:33: UP031 Use format specifiers instead of percent format mne/io/nirx/nirx.py:133:35: UP031 Use format specifiers instead of percent format mne/io/nirx/nirx.py:146:36: UP031 Use format specifiers instead of percent format mne/io/nirx/nirx.py:204:21: UP031 Use format specifiers instead of percent format mne/label.py:337:21: UP031 Use format specifiers instead of percent format mne/label.py:344:24: UP031 Use format specifiers instead of percent format mne/label.py:360:21: UP031 Use format specifiers instead of percent format mne/label.py:386:19: UP031 Use format specifiers instead of percent format mne/label.py:390:16: UP031 Use format specifiers instead of percent format mne/label.py:410:21: UP031 Use format specifiers instead of percent format mne/label.py:422:16: UP031 Use format specifiers instead of percent format mne/label.py:873:29: UP031 Use format specifiers instead of percent format mne/label.py:982:13: UP031 Use format specifiers instead of percent format mne/label.py:1023:17: UP031 Use format specifiers instead of percent format mne/label.py:1064:16: UP031 Use format specifiers instead of percent format mne/label.py:1087:20: UP031 Use format specifiers instead of percent format mne/label.py:1147:12: UP031 Use format specifiers instead of percent format mne/label.py:1243:13: UP031 Use format specifiers instead of percent format mne/label.py:1299:20: UP031 Use format specifiers instead of percent format mne/label.py:1371:24: UP031 Use format specifiers instead of percent format mne/label.py:1485:25: UP031 Use format specifiers instead of percent format mne/label.py:1710:19: UP031 Use format specifiers instead of percent format mne/label.py:2162:17: UP031 Use format specifiers instead of percent format mne/label.py:2241:57: UP031 Use format specifiers instead of percent format mne/label.py:2246:13: UP031 Use format specifiers instead of percent format mne/label.py:2391:21: UP031 Use format specifiers instead of percent format mne/label.py:2524:26: UP031 Use format specifiers instead of percent format mne/label.py:2751:27: UP031 Use format specifiers instead of percent format mne/label.py:2755:27: UP031 Use format specifiers instead of percent format mne/label.py:2804:23: UP031 Use format specifiers instead of percent format mne/minimum_norm/_eloreta.py:63:13: UP031 Use format specifiers instead of percent format mne/minimum_norm/_eloreta.py:123:13: UP031 Use format specifiers instead of percent format mne/minimum_norm/inverse.py:1082:17: UP031 Use format specifiers instead of percent format mne/minimum_norm/inverse.py:1111:21: UP031 Use format specifiers instead of percent format mne/minimum_norm/tests/test_inverse.py:132:25: UP031 Use format specifiers instead of percent format mne/minimum_norm/tests/test_inverse.py:142:25: UP031 Use format specifiers instead of percent format mne/minimum_norm/tests/test_inverse.py:229:57: UP031 Use format specifiers instead of percent format mne/minimum_norm/time_frequency.py:865:13: UP031 Use format specifiers instead of percent format mne/minimum_norm/time_frequency.py:938:17: UP031 Use format specifiers instead of percent format mne/minimum_norm/time_frequency.py:990:21: UP031 Use format specifiers instead of percent format mne/minimum_norm/time_frequency.py:993:17: UP031 Use format specifiers instead of percent format mne/morph.py:558:17: UP031 Use format specifiers instead of percent format mne/morph.py:739:14: UP031 Use format specifiers instead of percent format mne/morph.py:804:13: UP031 Use format specifiers instead of percent format mne/morph.py:843:13: UP031 Use format specifiers instead of percent format mne/morph.py:848:13: UP031 Use format specifiers instead of percent format mne/morph.py:901:17: UP031 Use format specifiers instead of percent format mne/morph.py:1324:25: UP031 Use format specifiers instead of percent format mne/morph.py:1452:13: UP031 Use format specifiers instead of percent format mne/morph.py:1465:13: UP031 Use format specifiers instead of percent format mne/morph.py:1543:43: UP031 Use format specifiers instead of percent format mne/morph_map.py:158:14: UP031 Use format specifiers instead of percent format mne/preprocessing/_fine_cal.py:157:13: UP031 Use format specifiers instead of percent format mne/preprocessing/_fine_cal.py:162:17: UP031 Use format specifiers instead of percent format mne/preprocessing/_fine_cal.py:194:13: UP031 Use format specifiers instead of percent format mne/preprocessing/_fine_cal.py:199:17: UP031 Use format specifiers instead of percent format mne/preprocessing/_fine_cal.py:522:21: UP031 Use format specifiers instead of percent format mne/preprocessing/_peak_finder.py:59:22: UP031 Use format specifiers instead of percent format mne/preprocessing/artifact_detection.py:248:19: UP031 Use format specifiers instead of percent format mne/preprocessing/ecg.py:325:30: UP031 Use format specifiers instead of percent format mne/preprocessing/ica.py:192:13: UP031 Use format specifiers instead of percent format mne/preprocessing/ica.py:938:21: UP031 Use format specifiers instead of percent format mne/preprocessing/ica.py:2787:26: UP031 Use format specifiers instead of percent format mne/preprocessing/ica.py:3378:9: UP031 Use format specifiers instead of percent format mne/preprocessing/infomax_.py:148:17: UP031 Use format specifiers instead of percent format mne/preprocessing/interpolate.py:49:13: UP031 Use format specifiers instead of percent format mne/preprocessing/maxwell.py:506:21: UP031 Use format specifiers instead of percent format mne/preprocessing/maxwell.py:572:17: UP031 Use format specifiers instead of percent format mne/preprocessing/maxwell.py:707:13: UP031 Use format specifiers instead of percent format mne/preprocessing/maxwell.py:724:25: UP031 Use format specifiers instead of percent format mne/preprocessing/maxwell.py:731:25: UP031 Use format specifiers instead of percent format mne/preprocessing/maxwell.py:745:17: UP031 Use format specifiers instead of percent format mne/preprocessing/maxwell.py:751:17: UP031 Use format specifiers instead of percent format mne/preprocessing/maxwell.py:907:17: UP031 Use format specifiers instead of percent format mne/preprocessing/maxwell.py:964:13: UP031 Use format specifiers instead of percent format mne/preprocessing/maxwell.py:1156:13: UP031 Use format specifiers instead of percent format mne/preprocessing/maxwell.py:1162:13: UP031 Use format specifiers instead of percent format mne/preprocessing/maxwell.py:1319:13: UP031 Use format specifiers instead of percent format mne/preprocessing/maxwell.py:1356:13: UP031 Use format specifiers instead of percent format mne/preprocessing/maxwell.py:1385:11: UP031 Use format specifiers instead of percent format mne/preprocessing/maxwell.py:2121:14: UP031 Use format specifiers instead of percent format mne/preprocessing/maxwell.py:2211:9: UP031 Use format specifiers instead of percent format mne/preprocessing/maxwell.py:2767:26: UP031 Use format specifiers instead of percent format mne/preprocessing/maxwell.py:2788:17: UP031 Use format specifiers instead of percent format mne/preprocessing/maxwell.py:2789:17: UP031 Use format specifiers instead of percent format mne/preprocessing/otp.py:91:13: UP031 Use format specifiers instead of percent format mne/preprocessing/otp.py:108:13: UP031 Use format specifiers instead of percent format mne/preprocessing/tests/test_eeglab_infomax.py:80:35: UP031 Use format specifiers instead of percent format mne/preprocessing/tests/test_maxwell.py:176:38: UP031 Use format specifiers instead of percent format mne/preprocessing/tests/test_maxwell.py:989:9: UP031 Use format specifiers instead of percent format mne/preprocessing/xdawn.py:204:17: UP031 Use format specifiers instead of percent format mne/preprocessing/xdawn.py:533:34: UP031 Use format specifiers instead of percent format mne/proj.py:220:23: UP031 Use format specifiers instead of percent format mne/proj.py:276:23: UP031 Use format specifiers instead of percent format mne/proj.py:371:19: UP031 Use format specifiers instead of percent format mne/proj.py:458:17: UP031 Use format specifiers instead of percent format mne/rank.py:103:30: UP031 Use format specifiers instead of percent format mne/rank.py:380:17: UP031 Use format specifiers instead of percent format mne/report/report.py:849:29: UP031 Use format specifiers instead of percent format mne/simulation/raw.py:126:13: UP031 Use format specifiers instead of percent format mne/simulation/raw.py:132:17: UP031 Use format specifiers instead of percent format mne/simulation/raw.py:316:9: UP031 Use format specifiers instead of percent format mne/simulation/raw.py:359:13: UP031 Use format specifiers instead of percent format mne/simulation/raw.py:501:25: UP031 Use format specifiers instead of percent format mne/simulation/raw.py:689:30: UP031 Use format specifiers instead of percent format mne/simulation/raw.py:707:13: UP031 Use format specifiers instead of percent format mne/simulation/raw.py:712:13: UP031 Use format specifiers instead of percent format mne/simulation/raw.py:718:13: UP031 Use format specifiers instead of percent format mne/simulation/raw.py:723:13: UP031 Use format specifiers instead of percent format mne/simulation/raw.py:848:13: UP031 Use format specifiers instead of percent format mne/simulation/raw.py:866:21: UP031 Use format specifiers instead of percent format mne/simulation/source.py:180:13: UP031 Use format specifiers instead of percent format mne/simulation/source.py:331:21: UP031 Use format specifiers instead of percent format mne/simulation/tests/test_raw.py:401:32: UP031 Use format specifiers instead of percent format mne/source_estimate.py:385:13: UP031 Use format specifiers instead of percent format mne/source_estimate.py:481:26: UP031 Use format specifiers instead of percent format mne/source_estimate.py:492:13: UP031 Use format specifiers instead of percent format mne/source_estimate.py:513:21: UP031 Use format specifiers instead of percent format mne/source_estimate.py:518:21: UP031 Use format specifiers instead of percent format mne/source_estimate.py:539:21: UP031 Use format specifiers instead of percent format mne/source_estimate.py:550:25: UP031 Use format specifiers instead of percent format mne/source_estimate.py:574:14: UP031 Use format specifiers instead of percent format mne/source_estimate.py:577:16: UP031 Use format specifiers instead of percent format mne/source_estimate.py:687:17: UP031 Use format specifiers instead of percent format mne/source_estimate.py:1559:17: UP031 Use format specifiers instead of percent format mne/source_estimate.py:2053:29: UP031 Use format specifiers instead of percent format mne/source_estimate.py:3515:17: UP031 Use format specifiers instead of percent format mne/source_estimate.py:3521:17: UP031 Use format specifiers instead of percent format mne/source_estimate.py:3556:13: UP031 Use format specifiers instead of percent format mne/source_estimate.py:3658:21: UP031 Use format specifiers instead of percent format mne/source_space/_source_space.py:323:32: UP031 Use format specifiers instead of percent format mne/source_space/_source_space.py:449:26: UP031 Use format specifiers instead of percent format mne/source_space/_source_space.py:451:26: UP031 Use format specifiers instead of percent format mne/source_space/_source_space.py:460:23: UP031 Use format specifiers instead of percent format mne/source_space/_source_space.py:464:16: UP031 Use format specifiers instead of percent format mne/source_space/_source_space.py:1428:17: UP031 Use format specifiers instead of percent format mne/source_space/_source_space.py:1444:21: UP031 Use format specifiers instead of percent format mne/source_space/_source_space.py:1449:21: UP031 Use format specifiers instead of percent format mne/source_space/_source_space.py:1463:24: UP031 Use format specifiers instead of percent format mne/source_space/_source_space.py:1525:9: UP031 Use format specifiers instead of percent format mne/source_space/_source_space.py:1536:27: UP031 Use format specifiers instead of percent format mne/source_space/_source_space.py:1554:13: UP031 Use format specifiers instead of percent format mne/source_space/_source_space.py:1608:38: UP031 Use format specifiers instead of percent format mne/source_space/_source_space.py:1617:17: UP031 Use format specifiers instead of percent format mne/source_space/_source_space.py:1625:21: UP031 Use format specifiers instead of percent format mne/source_space/_source_space.py:1632:41: UP031 Use format specifiers instead of percent format mne/source_space/_source_space.py:1828:13: UP031 Use format specifiers instead of percent format mne/source_space/_source_space.py:1831:21: UP031 Use format specifiers instead of percent format mne/source_space/_source_space.py:1889:21: UP031 Use format specifiers instead of percent format mne/source_space/_source_space.py:1999:13: UP031 Use format specifiers instead of percent format mne/source_space/_source_space.py:2069:9: UP031 Use format specifiers instead of percent format mne/source_space/_source_space.py:2075:21: UP031 Use format specifiers instead of percent format mne/source_space/_source_space.py:2093:13: UP031 Use format specifiers instead of percent format mne/source_space/_source_space.py:2633:11: UP031 Use format specifiers instead of percent format mne/source_space/_source_space.py:2641:26: UP031 Use format specifiers instead of percent format mne/source_space/_source_space.py:2650:17: UP031 Use format specifiers instead of percent format mne/source_space/_source_space.py:2663:13: UP031 Use format specifiers instead of percent format mne/source_space/_source_space.py:2715:26: UP031 Use format specifiers instead of percent format mne/source_space/_source_space.py:2724:17: UP031 Use format specifiers instead of percent format mne/source_space/_source_space.py:2895:9: UP031 Use format specifiers instead of percent format mne/source_space/_source_space.py:2979:21: UP031 Use format specifiers instead of percent format mne/source_space/_source_space.py:3173:21: UP031 Use format specifiers instead of percent format mne/stats/cluster_level.py:422:21: UP031 Use format specifiers instead of percent format mne/stats/cluster_level.py:931:17: UP031 Use format specifiers instead of percent format mne/stats/cluster_level.py:959:17: UP031 Use format specifiers instead of percent format mne/stats/cluster_level.py:979:13: UP031 Use format specifiers instead of percent format mne/stats/cluster_level.py:1140:21: UP031 Use format specifiers instead of percent format mne/stats/cluster_level.py:1155:21: UP031 Use format specifiers instead of percent format mne/stats/regression.py:93:15: UP031 Use format specifiers instead of percent format mne/stats/tests/test_parametric.py:151:34: UP031 Use format specifiers instead of percent format mne/stats/tests/test_parametric.py:158:39: UP031 Use format specifiers instead of percent format mne/surface.py:125:51: UP031 Use format specifiers instead of percent format mne/surface.py:140:47: UP031 Use format specifiers instead of percent format mne/surface.py:160:17: UP031 Use format specifiers instead of percent format mne/surface.py:1458:9: UP031 Use format specifiers instead of percent format mne/surface.py:1542:13: UP031 Use format specifiers instead of percent format mne/surface.py:1832:9: UP031 Use format specifiers instead of percent format mne/tests/test_annotations.py:239:21: UP031 Use format specifiers instead of percent format mne/tests/test_chpi.py:207:13: UP031 Use format specifiers instead of percent format mne/tests/test_chpi.py:226:46: UP031 Use format specifiers instead of percent format mne/tests/test_chpi.py:237:44: UP031 Use format specifiers instead of percent format mne/tests/test_coreg.py:221:16: UP031 Use format specifiers instead of percent format mne/tests/test_coreg.py:276:16: UP031 Use format specifiers instead of percent format mne/tests/test_cov.py:297:25: UP031 Use format specifiers instead of percent format mne/tests/test_cov.py:396:23: UP031 Use format specifiers instead of percent format mne/tests/test_dipole.py:218:48: UP031 Use format specifiers instead of percent format mne/tests/test_dipole.py:563:62: UP031 Use format specifiers instead of percent format mne/tests/test_dipole.py:577:29: UP031 Use format specifiers instead of percent format mne/tests/test_filter.py:91:50: UP031 Use format specifiers instead of percent format mne/tests/test_filter.py:410:23: UP031 Use format specifiers instead of percent format mne/tests/test_filter.py:914:18: UP031 Use format specifiers instead of percent format mne/tests/test_label.py:185:15: UP031 Use format specifiers instead of percent format mne/tests/test_line_endings.py:77:13: UP031 Use format specifiers instead of percent format mne/time_frequency/_stockwell.py:32:13: UP031 Use format specifiers instead of percent format mne/time_frequency/multitaper.py:289:13: UP031 Use format specifiers instead of percent format mne/time_frequency/multitaper.py:300:13: UP031 Use format specifiers instead of percent format mne/time_frequency/multitaper.py:317:13: UP031 Use format specifiers instead of percent format mne/time_frequency/tfr.py:500:13: UP031 Use format specifiers instead of percent format mne/time_frequency/tfr.py:520:13: UP031 Use format specifiers instead of percent format mne/time_frequency/tfr.py:2100:33: UP031 Use format specifiers instead of percent format mne/time_frequency/tfr.py:2102:33: UP031 Use format specifiers instead of percent format mne/time_frequency/tfr.py:2603:13: UP031 Use format specifiers instead of percent format mne/time_frequency/tfr.py:2604:14: UP031 Use format specifiers instead of percent format mne/time_frequency/tfr.py:2607:14: UP031 Use format specifiers instead of percent format mne/time_frequency/tfr.py:2773:13: UP031 Use format specifiers instead of percent format mne/time_frequency/tfr.py:2774:14: UP031 Use format specifiers instead of percent format mne/time_frequency/tfr.py:2777:14: UP031 Use format specifiers instead of percent format mne/time_frequency/tfr.py:2921:13: UP031 Use format specifiers instead of percent format mne/time_frequency/tfr.py:2924:13: UP031 Use format specifiers instead of percent format mne/transforms.py:226:13: UP031 Use format specifiers instead of percent format mne/transforms.py:665:17: UP031 Use format specifiers instead of percent format mne/transforms.py:1021:21: UP031 Use format specifiers instead of percent format mne/transforms.py:1142:17: UP031 Use format specifiers instead of percent format mne/transforms.py:1562:30: UP031 Use format specifiers instead of percent format mne/utils/_bunch.py:66:16: UP031 Use format specifiers instead of percent format mne/utils/_testing.py:246:28: UP031 Use format specifiers instead of percent format mne/utils/_testing.py:255:28: UP031 Use format specifiers instead of percent format mne/utils/_testing.py:299:24: UP031 Use format specifiers instead of percent format mne/utils/_testing.py:347:21: UP031 Use format specifiers instead of percent format mne/utils/check.py:68:13: UP031 Use format specifiers instead of percent format mne/utils/check.py:74:13: UP031 Use format specifiers instead of percent format mne/utils/check.py:307:48: UP031 Use format specifiers instead of percent format mne/utils/check.py:343:13: UP031 Use format specifiers instead of percent format mne/utils/check.py:749:17: UP031 Use format specifiers instead of percent format mne/utils/check.py:921:15: UP031 Use format specifiers instead of percent format mne/utils/check.py:932:13: UP031 Use format specifiers instead of percent format mne/utils/check.py:1074:17: UP031 Use format specifiers instead of percent format mne/utils/check.py:1085:13: UP031 Use format specifiers instead of percent format mne/utils/check.py:1155:16: UP031 Use format specifiers instead of percent format mne/utils/check.py:1157:16: UP031 Use format specifiers instead of percent format mne/utils/check.py:1229:13: UP031 Use format specifiers instead of percent format mne/utils/config.py:331:13: UP031 Use format specifiers instead of percent format mne/utils/dataframe.py:20:21: UP031 Use format specifiers instead of percent format mne/utils/docs.py:4126:29: UP031 Use format specifiers instead of percent format mne/utils/docs.py:4434:28: UP031 Use format specifiers instead of percent format mne/utils/docs.py:4736:12: UP031 Use format specifiers instead of percent format mne/utils/docs.py:4772:29: UP031 Use format specifiers instead of percent format mne/utils/docs.py:4966:28: UP031 Use format specifiers instead of percent format mne/utils/mixin.py:283:25: UP031 Use format specifiers instead of percent format mne/utils/mixin.py:449:21: UP031 Use format specifiers instead of percent format mne/utils/numerics.py:324:22: UP031 Use format specifiers instead of percent format mne/utils/numerics.py:496:13: UP031 Use format specifiers instead of percent format mne/utils/numerics.py:503:13: UP031 Use format specifiers instead of percent format mne/utils/numerics.py:528:13: UP031 Use format specifiers instead of percent format mne/utils/numerics.py:534:13: UP031 Use format specifiers instead of percent format mne/utils/numerics.py:686:28: UP031 Use format specifiers instead of percent format mne/utils/numerics.py:736:28: UP031 Use format specifiers instead of percent format mne/utils/numerics.py:807:26: UP031 Use format specifiers instead of percent format mne/utils/numerics.py:813:26: UP031 Use format specifiers instead of percent format mne/utils/numerics.py:816:26: UP031 Use format specifiers instead of percent format mne/utils/numerics.py:833:17: UP031 Use format specifiers instead of percent format mne/utils/numerics.py:844:34: UP031 Use format specifiers instead of percent format mne/utils/numerics.py:886:17: UP031 Use format specifiers instead of percent format mne/utils/numerics.py:893:21: UP031 Use format specifiers instead of percent format mne/utils/numerics.py:1054:26: UP031 Use format specifiers instead of percent format mne/utils/numerics.py:1105:18: UP031 Use format specifiers instead of percent format mne/utils/tests/test_numerics.py:321:38: UP031 Use format specifiers instead of percent format mne/viz/_3d.py:200:17: UP031 Use format specifiers instead of percent format mne/viz/_3d.py:236:30: UP031 Use format specifiers instead of percent format mne/viz/_3d.py:1796:26: UP031 Use format specifiers instead of percent format mne/viz/_3d.py:1800:13: UP031 Use format specifiers instead of percent format mne/viz/_3d.py:1809:26: UP031 Use format specifiers instead of percent format mne/viz/_3d.py:1812:13: UP031 Use format specifiers instead of percent format mne/viz/_3d.py:1819:21: UP031 Use format specifiers instead of percent format mne/viz/_3d.py:2520:44: UP031 Use format specifiers instead of percent format mne/viz/_3d.py:2936:21: UP031 Use format specifiers instead of percent format mne/viz/_3d.py:2948:17: UP031 Use format specifiers instead of percent format mne/viz/_3d.py:2952:21: UP031 Use format specifiers instead of percent format mne/viz/_3d.py:4000:17: UP031 Use format specifiers instead of percent format mne/viz/_3d.py:4007:13: UP031 Use format specifiers instead of percent format mne/viz/_brain/_brain.py:1883:25: UP031 Use format specifiers instead of percent format mne/viz/_brain/_brain.py:3463:25: UP031 Use format specifiers instead of percent format mne/viz/_brain/_brain.py:3935:17: UP031 Use format specifiers instead of percent format mne/viz/_brain/_brain.py:3944:17: UP031 Use format specifiers instead of percent format mne/viz/_brain/_brain.py:3957:22: UP031 Use format specifiers instead of percent format mne/viz/_brain/_brain.py:4128:28: UP031 Use format specifiers instead of percent format mne/viz/_brain/_brain.py:4130:28: UP031 Use format specifiers instead of percent format mne/viz/_brain/colormap.py:121:13: UP031 Use format specifiers instead of percent format mne/viz/_brain/surface.py:124:41: UP031 Use format specifiers instead of percent format mne/viz/backends/_utils.py:301:30: UP031 Use format specifiers instead of percent format mne/viz/backends/tests/test_renderer.py:195:9: UP031 Use format specifiers instead of percent format mne/viz/evoked.py:196:21: UP031 Use format specifiers instead of percent format mne/viz/evoked.py:216:18: UP031 Use format specifiers instead of percent format mne/viz/evoked.py:630:25: UP031 Use format specifiers instead of percent format mne/viz/evoked.py:1871:25: UP031 Use format specifiers instead of percent format mne/viz/misc.py:872:27: UP031 Use format specifiers instead of percent format mne/viz/misc.py:1028:26: UP031 Use format specifiers instead of percent format mne/viz/misc.py:1342:13: UP031 Use format specifiers instead of percent format mne/viz/misc.py:1414:17: UP031 Use format specifiers instead of percent format mne/viz/misc.py:1538:30: UP031 Use format specifiers instead of percent format mne/viz/tests/test_3d_mpl.py:92:16: UP031 Use format specifiers instead of percent format mne/viz/topo.py:558:19: UP031 Use format specifiers instead of percent format mne/viz/topo.py:577:18: UP031 Use format specifiers instead of percent format mne/viz/topo.py:580:52: UP031 Use format specifiers instead of percent format mne/viz/topomap.py:1273:13: UP031 Use format specifiers instead of percent format mne/viz/topomap.py:3159:17: UP031 Use format specifiers instead of percent format mne/viz/topomap.py:3161:17: UP031 Use format specifiers instead of percent format mne/viz/utils.py:1982:13: UP031 Use format specifiers instead of percent format mne/viz/utils.py:2154:25: UP031 Use format specifiers instead of percent format mne/viz/utils.py:2215:17: UP031 Use format specifiers instead of percent format mne/viz/utils.py:2323:21: UP031 Use format specifiers instead of percent format ```

Ruff does not find all occurrences though, so in a second step, I'd do a global search for % (space percent space) and see what else crops up (I currently find 1617 results, but this likely includes the 359 occurrences that Ruff reported).

Let me know if you have further questions!

Aditya3425-Fst commented 7 months ago

@cbrnr can you tell me the command for passing the repository test on my local machine .

drammock commented 7 months ago

@cbrnr can you tell me the command for passing the repository test on my local machine .

the test for checking if you've fixed them all is the same command used for finding the errors: ruff check mne --config pyproject.toml --select UP031 (run from the root directory of your clone of the repository)

ughrima commented 7 months ago

I've been working on resolving this issue, and each time I think I've fixed them, more errors seem to appear later on. This is causing some confusion, and I'm unsure about when it's the right time to push my work. Can someone please help me out?

cbrnr commented 7 months ago

We currently have @Aditya3425-Fst working on this in #12405. If you want to contribute, please comment directly over there.

hasrat17 commented 6 months ago

Hey @cbrnr if this issue is still not resolved, then I would like to work on this. Can you assign it to me?

hasrat17 commented 6 months ago

Hi @cbrnr I have one doubt: in some places, we have code like this name_pattern = "%s_div%%i%s" % (basename, name_ext) names = tuple(name_pattern % i for i in range(1, n_parts + 1)) Here I am changing both the %s to f string like this name_pattern = f"{basename}_div%%i{name_ext}" but for the next part, as we are using %%i I am using PERCENT only instead of f string names = tuple(name_pattern % i for i in range(1, n_parts + 1)) So this is FINE, or do I need to change the code for using f string here also?

agramfort commented 6 months ago

see

basename = "toto" name_ext = ".txt" "%s_div%%i%s" % (basename, name_ext) 'toto_div%i.txt' f"{basename}_div%i{name_ext}" 'toto_div%i.txt'

so f"{basename}_div%i{name_ext}" should be the correct replacement.

Message ID: @.***>

sappelhoff commented 1 month ago

Re-opening, because even once #12758 is merged, there will still be many % strings to get rid of.

Please search globally for " % to find them.