Open drammock opened 23 hours ago
one possible downside to the "spinoff" approach that I've just thought of, is the risk of losing git history (edit: and hence contributor credit) for the existing code. I think there's probably a way to preserve it, via something like:
from .forward import whatever
to from mne.forward import whatever
)+1, glad someone is working on simulation!
Thank you, @drammock! Tagging @minajamshidi and @astudenova to keep them in the loop.
+1 to spin off under mne-tools/mne-simulation
!
+1 for spin off with some git history
magic suggested by @drammock . There is probably a way to do it that preserves committer and date and such but mangles the commit numbers (which is okay)
Go for it π
Also π for spin off!
+1 from me, too. Really excited about the cool options that @ctrltz, @minajamshidi, and @astudenova support in MEEGsim! π
+1 supporting simulation would help so much research in this space.
Hi @mne-tools/mne-python-steering-committee
@ctrltz and colleagues have been doing some work on simulating MNE objects (above and beyond what we currently support), in the new https://github.com/ctrltz/meegsim package. They have expressed interest in incorporating their work into MNE-Python, and after a few discussions with @larsoner @agramfort and @britta-wstnr we've settled on a tentative plan to "spin off" our existing simulation code into a new package (
mne-simulation
or so) similar to what was done for connectivity a few years ago, and then give @ctrltz and colleagues write-access to that repo so they can add their code and also have a much smaller/faster test/CI suite. Existing simulation code would be deprecated in MNE-Python release 1.9 and removed in 1.10.This issue is your chance to weigh in on whether you think it best to: