search

mne-tools / mne-python

MNE: Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python
https://mne.tools
BSD 3-Clause "New" or "Revised" License
2.66k stars 1.31k forks source link

plot_topo cosmetics #1888

Closed jona-sassenhagen closed 9 years ago

jona-sassenhagen commented 9 years ago

mne.viz.plot_topo seems a bit half-assed right now, unless I'm missing something. However, when suggesting to a student of mine to use MNE for a basic ERP analysis, I realised for people who'd use MNE mainly for plain old boring ERPs, this is probably an essential feature. I'm currently adding all the minor cosmetic things necessary for basic usage:

And so on. Is this a good idea, or am I just duplicating stuff already done better elsewhere? I'll submit a PR if you think it's a good idea. Example of status quo of my additions:

unknown

agramfort commented 9 years ago

a very welcome contribution !

mainakjas commented 9 years ago

yep, I have wanted the legends too :) I write my custom scripts for that but it would be great if it can be integrated into MNE

dengemann commented 9 years ago

Sounds great!

2015-03-22 14:53 GMT+01:00 mainakjas notifications@github.com:

yep, I have wanted the legends too :) I write my custom scripts for that but it would be great if it can be integrated into MNE

— Reply to this email directly or view it on GitHub https://github.com/mne-tools/mne-python/issues/1888#issuecomment-84610966 .

teonbrooks commented 9 years ago

closing for pr https://github.com/mne-tools/mne-python/pull/1890.