search

mne-tools / mne-python

MNE: Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python
https://mne.tools
BSD 3-Clause "New" or "Revised" License
2.72k stars 1.32k forks source link

BUG/API issue with multi_comp.bonferroni_correction #2227

Closed dengemann closed 9 years ago

dengemann commented 9 years ago

Do people agree that this is a bug, at least a very unexpected output: https://github.com/mne-tools/mne-python/blob/master/mne/stats/multi_comp.py#L101

pval_corrected should instead be used for creating the output mask.

@agramfort @Eric89GXL @mainakjas

mainakjas commented 9 years ago

indeed, looks like a bug to me

dengemann commented 9 years ago

probably one of @agramfort 's early experiments on how to impvrove the sensitivity of MEG group analyses ... ;)

agramfort commented 9 years ago

oh my goodness... it's a horrible bug that has been there for ages ... :-/

PR more than welcome...

dengemann commented 9 years ago

Ok, I'm on it.