search

mne-tools / mne-python

MNE: Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python
https://mne.tools
BSD 3-Clause "New" or "Revised" License
2.66k stars 1.31k forks source link

BUG: GAT shouldn't take non-partition cv #3624

Closed kingjr closed 7 years ago

kingjr commented 7 years ago

We should create an error when the cv is not a partition (e.g. ShuffleSplit with overlapping tests sets). We currently just iteratively replace the y_pred[test].

larsoner commented 7 years ago

Are these warnings related (from plot_decoding_csp_eeg.py)?

/home/larsoner/.local/lib/python2.7/site-packages/sklearn/lda.py:4: DeprecationWarning: lda.LDA has been moved to discriminant_analysis.LinearDiscriminantAnalysis in 0.17 and will be removed in 0.19
  "in 0.17 and will be removed in 0.19", DeprecationWarning)
/home/larsoner/.local/lib/python2.7/site-packages/sklearn/cross_validation.py:44: DeprecationWarning: This module was deprecated in version 0.18 in favor of the model_selection module into which all the refactored classes and functions are moved. Also note that the interface of the new CV iterators are different from that of this module. This module will be removed in 0.20.
  "This module will be removed in 0.20.", DeprecationWarning)
kingjr commented 7 years ago

nope, different issue.

The second warning is linked to sklearn big change of cross_validation to model_selection module.