search

mne-tools / mne-python

MNE: Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python
https://mne.tools
BSD 3-Clause "New" or "Revised" License
2.69k stars 1.31k forks source link

Bug in _prepare_beamformer_input? #4475

Closed wmvanvliet closed 7 years ago

wmvanvliet commented 7 years ago

Is this a bug?

def _prepare_beamformer_input(info, forward, label, picks, pick_ori):
    """Input preparation common for all beamformer functions.

    Check input values, prepare channel list and gain matrix. For documentation
    of parameters, please refer to _apply_lcmv.
    """
    is_free_ori = forward['source_ori'] != FIFF.FIFFV_MNE_FREE_ORI

Shouldn't that last line be:

    is_free_ori = forward['source_ori'] == FIFF.FIFFV_MNE_FREE_ORI

?

wmvanvliet commented 7 years ago

@rgoj

wmvanvliet commented 7 years ago

NM, I'm being silly.