Closed massich closed 5 years ago
Edited, LGTM
I guess I contributed, unless there is a minimum amount of code to be included in the list?
unless there is a minimum amount of code to be included in the list?
1 line :)
@massich how did you make the list? Following the wiki I can get:
larsoner@bunk:~/python/mne-python$ git rev-list -n 1 v0.16 | xargs -I commit git log commit.. | git shortlog -s -n | sed "s/^[ \t]*/* /"
* 129 Eric Larson
* 35 Joan Massich
* 28 Alexandre Gramfort
* 24 Jona Sassenhagen
* 23 Stefan Appelhoff
* 12 Clemens Brunner
* 8 Mainak Jas
* 8 Marijn van Vliet
* 5 Thomas Hartmann
* 3 Denis A. Engemann
* 3 Henrich Kolkhorst
* 3 Luke Bloy
* 3 Teon Brooks
* 2 Antoine Gauthier
* 2 Britta Westner
* 2 Christian Brodbeck
* 2 Thomas Jochmann
* 1 Daniel McCloy
* 1 DavidSabbagh
* 1 Jasper J.F. van den Bosch
* 1 Jen Evans
* 1 Johan van der Meer
* 1 Kambiz Tavabi
* 1 Lorenz Esch
* 1 MJAS1
* 1 Marcin Koculak
* 1 Peter J. Molfese
* 1 Sam Perry
* 1 Sergey Antopolskiy
* 1 Sheraz Khan
* 1 Stefan Repplinger
* 1 Steven Bethard
* 1 Teekuningas
* 1 Tom Dupré la Tour
* 1 Tristan Stenner
* 1 buildqa
* 1 ezemikulan
* 1 hubertjb
* 1 jeythekey
* 1 sarasommariva
And @cbrnr is listed. We should probably adapt this to produce an alphabetized list of names since this is what we show now instead of commit counts.
Here, I'll clean up this list and update the wiki:
larsoner@bunk:~/python/mne-python$ git rev-list -n 1 v0.16 | xargs -I commit git log commit.. | git shortlog -s | sed "s/^\s*[0-9]*[ \t]*/- /"
- Alexandre Gramfort
- Antoine Gauthier
- Britta Westner
- Christian Brodbeck
- Clemens Brunner
- Daniel McCloy
- DavidSabbagh
- Denis A. Engemann
- Eric Larson
- Henrich Kolkhorst
- Jasper J.F. van den Bosch
- Jen Evans
- Joan Massich
- Johan van der Meer
- Jona Sassenhagen
- Kambiz Tavabi
- Lorenz Esch
- Luke Bloy
- MJAS1
- Mainak Jas
- Marcin Koculak
- Marijn van Vliet
- Peter J. Molfese
- Sam Perry
- Sergey Antopolskiy
- Sheraz Khan
- Stefan Appelhoff
- Stefan Repplinger
- Steven Bethard
- Teekuningas
- Teon Brooks
- Thomas Hartmann
- Thomas Jochmann
- Tom Dupré la Tour
- Tristan Stenner
- buildqa
- ezemikulan
- hubertjb
- jeythekey
- sarasommariva
did you already update the mailmap?
@larsoner I did not know about the wiki. I copy pasted all the changes in this release in whats new, some regex magic, got a list of all the authors and then I unique them.
But for sure your list is fairer. I'll take it into account next time.
I partially updated the mailmap in my decoding doc PR. Waiting to hear back from the last couple of people then it should hopefully be a list of actual names
+1 for the release notes.
What does the .mailmap
do? (Wondering if I should add myself there)
It's used to attribute commits to correct people that otherwise appear to come from different ones. Your name already showed up properly in the list of names when we auto-generated the contributor list, so congrats 1) your git config
already seems correct and consistent across devices, 2) you made your lives easier because of this, and 3) I don't think there is anything else you need to do :)
hahaha great! And while we are at it, why is the AUTHORS.rst
so limited?
We should probably just remove it. It does not get updated and I don't think it's used or useful
yes we are sloppy with AUTHORS.txt ...
I put together a release note, please feel free to comment on it (or edit).
Dear community,
We are very pleased to announce the new 0.17 release of MNE-Python (http://martinos.org/mne/stable/).
A few highlights
Notable API changes
For a full list of improvements and API changes, see: http://martinos.org/mne/stable/whats_new.html#version-0-17
To install the latest release the following command should do the job:
As usual, we welcome your bug reports, feature requests, critiques, and contributions.
Some links:
Follow us on Twitter: https://twitter.com/mne_news
Regards, The MNE-Python developers
40 people made commits that contributed to this release (in alphabetical order):