mne-tools / mne-python

MNE: Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python
https://mne.tools
BSD 3-Clause "New" or "Revised" License
2.69k stars 1.31k forks source link

Inconsistant rank estimation and API in beamformers #5879

Closed agramfort closed 4 years ago

agramfort commented 5 years ago

I am with @britta-wstnr and @LauriParkkonen and after debugging some issues with phantom and simulated data using beamformer code here a list of things that we think should be addressed:

We propose to create a unifying function call

rank = compute_rank(inst, scalings=None, rank='auto', info=None)

where inst can be Raw or Epochs or Covariance (info needed if Covariance. This function would be called early in inverse pipeline so we pass explicitly and int to all subsequent functions.

Started in #5876.

Remaining items:

agramfort commented 4 years ago

to close @larsoner ?

larsoner commented 4 years ago

We still haven't dealt with the XXX's having to do with tolerance levels, but we can close and get to it someday if we need to