Closed HanBnrd closed 3 years ago
Hi, just pinging @rob-luke. I will try to have a look at it ASAP.
I created a separate issue for the sourcePos3D problem: #9308
We should ensure we follow the SNIRF standard. However, from memory not all files in the examples repo do. What specific part of our reader is diverging from the standard?
Thanks @rob-luke, you are right, my bad. Both files do not pass the snirf_validator.py.
Some modifications of the samples are planned according to https://github.com/fNIRS/snirf/issues/44, so maybe better to close this issue. Sorry about that.
That's good to know. Thanks for checking this. I probably wouldn't trust that validator either. Just the spec is valid
I just received some SNIRF files from NIRx. So I will test and ensure these load in to our reader.
Describe the bug
The function read_raw_snirf returns errors with the official samples from https://github.com/fNIRS/snirf-samples/.
Steps to reproduce
With Simple_Probe.snirf:
With minimum_example.snirf:
Expected results
and
respectively.
Actual results
and
respectively.
Additional information
This tutorial from MNE-NIRS works fine on my machine.