added android build commands

mnemosyne-proj / mnemosyne

Mnemosyne: efficient learning with powerful digital flash-cards.

https://mnemosyne-proj.org/

Other

507 stars 74 forks source link

added android build commands #246

Closed acezalba closed 1 year ago

acezalba commented 1 year ago

Re: https://github.com/mnemosyne-proj/mnemosyne/issues/245

Changes:

added python-for-android and dependencies in pyproject.toml and requirements.txt
added android build commands to makefile
documented usage of android build commands in README.md
updated runtime requirements in README.md
some typo fixes.

pbienst commented 1 year ago

I think idea and .cxx shouldn't be added to version control. As for the rest of the patch, it'll take me a while to review it completely, though...

pbienst commented 1 year ago

Also, can you keep the previous functionality of 'make android' intact, perhaps under a different name? I only use Linux to update the libraries, which is very rare. Daily development is under Windows, and there I don't need to touch the binaries, but just use those from version control. I.e., I suggest your new functionality only deals with generating the required binaries under Linux, but leaves the rest of the Android development workflow alone, such that also Windows developers can contribute.

acezalba commented 1 year ago

I'll create a pull request for these changes some other time. Removing .idea and cxx from the project tree via git-filter-repo has rewritten the deltas for my entire develop branch, making it look as if it's a complete overwrite.