search

mnemosyne-proj / mnemosyne

Mnemosyne: efficient learning with powerful digital flash-cards.
https://mnemosyne-proj.org/
Other
507 stars 74 forks source link

Bypass "makefile" when using pep517 build (FreeBSD packager) #253

Closed nunotexbsd closed 10 months ago

nunotexbsd commented 10 months ago

Hello,

Does makefile needs to be run when using pep517 build, called by: https://github.com/mnemosyne-proj/mnemosyne/blob/ff55de843a246c991dccd07268c09e3b12f7532d/pyproject.toml#L9C1-L10C45 ?

If makefile is deleted, I get a make error but it installs at the end: Successfully built mnemosyne_proj-2.11-cp39-cp39-freebsd_14_0_release_amd64.whl

* Getting build dependencies for wheel...
* Building wheel...
make[1]: Entering directory '/wrkdirs/usr/ports/games/py-mnemosyne-proj/work-py39/mnemosyne_proj-2.11'
# Just the bare minimum to get things running
make -C mnemosyne/pyqt_ui
make[2]: Entering directory '/wrkdirs/usr/ports/games/py-mnemosyne-proj/work-py39/mnemosyne_proj-2.11/mnemosyne/pyqt_ui'
make[2]: Nothing to be done for 'default'.
make[2]: Leaving directory '/wrkdirs/usr/ports/games/py-mnemosyne-proj/work-py39/mnemosyne_proj-2.11/mnemosyne/pyqt_ui'
make[1]: Leaving directory '/wrkdirs/usr/ports/games/py-mnemosyne-proj/work-py39/mnemosyne_proj-2.11'
Successfully built mnemosyne_proj-2.11-cp39-cp39-freebsd_14_0_release_amd64.whl

Thanks

pbienst commented 10 months ago

Yes, we need to rely on some external commands to build Python files from ui files.