mnemosyne-proj / mnemosyne

Mnemosyne: efficient learning with powerful digital flash-cards.
https://mnemosyne-proj.org/
Other
513 stars 75 forks source link

`/usr/pixmaps` polluting #283

Open kuraga opened 1 month ago

kuraga commented 1 month ago
$ make
<...>
$ make DESTDIR="image" install-system
<...>
$ find image/usr/pixmaps/
image/usr/pixmaps/
image/usr/pixmaps/tags.png
image/usr/pixmaps/edit_add.png
image/usr/pixmaps/edit.png
image/usr/pixmaps/add.xcf
image/usr/pixmaps/mnemosyne_small.png
image/usr/pixmaps/mnemosyne.ico
image/usr/pixmaps/mnemosyne.icns
image/usr/pixmaps/exit.png
image/usr/pixmaps/image.png
image/usr/pixmaps/statistics.png
image/usr/pixmaps/bold.png
image/usr/pixmaps/highlight.png
image/usr/pixmaps/deck.xcf
image/usr/pixmaps/filesave.png
image/usr/pixmaps/filenew.png
image/usr/pixmaps/edit.xcf
image/usr/pixmaps/filesaveas.png
image/usr/pixmaps/sound.png
image/usr/pixmaps/delete.png
image/usr/pixmaps/configure.png
image/usr/pixmaps/fileopen.png
image/usr/pixmaps/cards.png
image/usr/pixmaps/cancel.png
image/usr/pixmaps/mnemosyne.png
image/usr/pixmaps/italic.png
image/usr/pixmaps/latex.png
image/usr/pixmaps/deck.png
image/usr/pixmaps/underline.png
image/usr/pixmaps/delete.xcf
image/usr/pixmaps/mnemosyne_large.png
image/usr/pixmaps/mnemosyne.svg
image/usr/pixmaps/cards.xcf
image/usr/pixmaps/add.png

I don't know the rules of /usr/pixmaps polluting but writing some "global" files such as /usr/pixmaps/cancel.png is odd...

kuraga commented 1 month ago

I guess they should be at /usr/share/pixmaps/mnemosyne.

kuraga commented 1 month ago

?

https://github.com/mnemosyne-proj/mnemosyne/blob/cf6e8b0ca5f84b0696ebc8087a5714f7aa55e850/setup.py#L109-L112

kuraga commented 1 month ago

See also: https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=mnemosyne&id=e5ee1fcd9ea84572585e0c434e5a0995bbbd1222#n58

pbienst commented 1 month ago

I not able to devote time to Mnemosyne these days, but if you care enough about this, I'm happy to accept patches.