search

mnesarco / MarzWorkbench

FreeCAD Workbench for guitar design
GNU General Public License v3.0
82 stars 19 forks source link

fix import of Part WB #2

Closed tomate44 closed 4 years ago

tomate44 commented 4 years ago

Hello, Your workbench look very interesting. However, I had several errors at first try, all similar to : "AttributeError: module 'FreeCAD.Part' has no attribute 'makeCircle'" the culprit is "from FreeCAD import Part" PS : I am running FC master, on Manjaro Linux

mnesarco commented 4 years ago

Hi @tomate44 , I cannot reproduce your Issue. I am using FC0.19 and FC0.18.4 on Linux Mint.

mnesarco commented 4 years ago

Confirmed, it is not compatible with FC0.18, but your PR is conflicting other files and I have found other parts that are non compatible with FC0.18.

mnesarco commented 4 years ago

I have fixed imports in all files to make it FC0.18 friendly, but it is not the only problem with FC0.18.

tomate44 commented 4 years ago

OK. I just pulled your latest commits, and realized you fixed the imports. It is working here, now. Thanks a lot. I am closing the PR.

mnesarco commented 4 years ago

Unfortunately, custom shapes does not work with FC0.18 at the moment.

mnesarco commented 4 years ago

BTW, the Wiki contains some useful info now: https://github.com/mnesarco/MarzWorkbench/wiki

tomate44 commented 4 years ago

I am using FC 0.19,so I was able to give a test at importing a body shape. Great work!