mnesarco / MarzWorkbench

FreeCAD Workbench for guitar design
GNU General Public License v3.0
82 stars 19 forks source link

asymmetric neck shape #23

Open zu4lu opened 1 year ago

zu4lu commented 1 year ago

Hi Frank, last version of maz is very good, but i'm missing one feature badly, the asymmetric neck shapes(if you ever played one of these, you know what i mean). Is this possible? Michael

mnesarco commented 1 year ago

Asymetric necks are supported in the c++ in-development version. But it is not public yet.

mnesarco commented 1 year ago

https://forum.freecad.org/viewtopic.php?t=58729&start=10#p505612

brotherdust commented 1 year ago

Been looking forward to seeing your development for a couple of years now! I’ve got tons of design ideas that I’d love to try out. I’m considering just biting the bullet and doing a fully parametric design in CADQuery (CAD as code) because I don’t know what your timeline is. If theres any help I can offer, I’ll be happy to contribute. I’m good at technical docs.

mnesarco commented 1 year ago

Thank you. The best help I need is in cross platform packaging of the c++ version for distribution.

I have no timeline, I do this in spare time.

image

I have not published it yet because there are many things pending to package this as a product.

zu4lu commented 1 year ago

Looks fantastic. I read the wiki once again, and found the custom neckshapes( don't ask, why i didn't found it before :-) ). So my understanding is, there are asymmetric shapes possible, but only to one side. So center near the bass strings on the zero fret and center near the high strings on the 12th fret is not possible? (with the current workbench)

mnesarco commented 1 year ago

@zu4lu Yes in the current WB it is possible to define a custom neck profile with a single asymmetry but not compound asymmetry.

https://github.com/mnesarco/MarzWorkbench/wiki/Neck-Profile-Specs

zu4lu commented 1 year ago

Thank you, will you make it possible it in the workbench?

mnesarco commented 1 year ago

Thank you, will you make it possible it in the workbench?

Maybe.

mnesarco commented 6 months ago

I am working on an editor for neck profiles. It will support double asymmetric necks and it will be available in the FreeCAD version.

zu4lu commented 6 months ago

Hi, great news, i'm looking forward to it

Am Montag, Mai 06, 2024 17:59 CEST, schrieb Frank David Martínez M @.>:     I am working on an editor for neck profiles. It will support double asymmetric necks and it will be available in the FreeCAD version. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.>[ { @.": "http://schema.org", @.": "EmailMessage", "potentialAction": { @.": "ViewAction", "target": "https://github.com/mnesarco/MarzWorkbench/issues/23#issuecomment-2096390184", "url": "https://github.com/mnesarco/MarzWorkbench/issues/23#issuecomment-2096390184", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { @.": "Organization", "name": "GitHub", "url": "https://github.com" } } ]***> --  lg Michael Kaufmann

zu4lu commented 5 months ago

Hi Frank, maybe this will help. I make my shapes based on this and its fantastic. https://www.kappi.com/blog/2012/10/asymmetric-neck-shapes/

mnesarco commented 5 months ago

@zu4lu thank you for the link, but i already have developed the double asymmetric neck editor in my private c++ version. I just have had not time to port it here. The idea is actually pretty similar:

image

zu4lu commented 5 months ago

good news, thanks