search

mneuhaus / Famelo.PDF

GNU Lesser General Public License v3.0
19 stars 21 forks source link

Exception log entries #9

Closed vixe76 closed 8 years ago

vixe76 commented 8 years ago

First of all thx for this nice package.

The pdf rendering works like a charm and without any exception. But the exception log contains exceptions if the controller action of my package which creates the pdf doesn't have a own template. My workaround is creating an empty template for my controller action.

Can you fix this ... so that no empty template is required?

Best Falk

mneuhaus commented 8 years ago

Hey, you're welcome :)

Could you post an example of that Exception?

vixe76 commented 8 years ago

Sure ... 2016021814272160a161.txt

vixe76 commented 8 years ago

Btw. Flow 2.3.11 is in use

mneuhaus commented 8 years ago

Hmm, that error doesn't originate in the PDF Package itself, it comes from the controllerAction in which you use the PDF Package.

Which generator do you use(mpdf, webkit, etc)? Which method do you use(send, download, save)?

vixe76 commented 8 years ago

mpdf with send

mneuhaus commented 8 years ago

ah, ok, i'm missing an exit, obviously, so it just continues after the pdf generation currently. i'll fix that :)

mneuhaus commented 8 years ago

https://github.com/mneuhaus/Famelo.PDF/commit/79c3b9b8477062dd0df47fbb394af44192b0a714 should fix this :)

mneuhaus commented 8 years ago

and here's the bugfix release: https://github.com/mneuhaus/Famelo.PDF/releases/tag/1.0.1

you should be able to update safely with composer now:

composer update famelo/pdf
vixe76 commented 8 years ago

insanely fastest fix I've ever seen :-) ... thx ... :+1:

mneuhaus commented 8 years ago

you're welcome :)