search

mneumann / rust-msgpack

[DEPRECATED] msgpack.org implementation for Rust language. Please use https://github.com/3Hren/msgpack-rust
121 stars 31 forks source link

Does not compile with rustc 1.7.0 #55

Open zbynekwinkler opened 8 years ago

zbynekwinkler commented 8 years ago

Complains about #![feature(slice_splits)] not available on stable channel.

The version 0.1.0 on crates.io does not compile either.

zbynekwinkler commented 8 years ago

According to https://travis-ci.org/mneumann/rust-msgpack#L135 the #![feature(slice_splits)] is not needed as it is stable. The log shows it has been built with rust 1.8 but that did not work for me either. Further investigation shows it is due to https://github.com/BurntSushi/byteorder/commit/e429dfb9ccb74e32c5f1800a20318ea2162ef262

Rust 1.6 stabilized `read_exact`, which gives us the same functionality without
having to wrap `std::io::Error`. Removing the custom error type makes this
a breaking change, and users will have to replace uses of `byteorder::Error`
with `std::io::Error`.
Palpatineli commented 8 years ago

same failure with rustc 1.10.0 on debian testing x64 as of 2016-08-05

kallisti5 commented 8 years ago

same failure with rustc 1.11.0 on Fedora 25. There is a pull request open to fix this one... anyone going to review / accept?