mnezerka / dnslib

Simple C++ library designed for encoding and decoding of DNS protocol packets
62 stars 23 forks source link

fakesrv: listen address parameter was ignored #3

Closed victor-istomin closed 6 years ago

victor-istomin commented 6 years ago

Hi,

It looks like -l {address} parameter was ignored in example fakesrv. This is fixup (commit# 758ab32).

Additionally, it looks like both tabs and spaces were used as indentation in this like, so I've fixed this in order to improve code look with default github's tabwidth=8 (commit# ac1df59).

Kind regards, Victor.

mnezerka commented 6 years ago

Merged.

Thank you Victor.

Michal

On Tue, Sep 25, 2018 at 10:50 PM Victor Istomin notifications@github.com wrote:

Hi,

It looks like -l parameter was ignored in example fakesrv. This is fixup (commit# 758ab32 https://github.com/mnezerka/dnslib/commit/758ab328c2cce2d4bdb4372bdcd35dbcf09754ae ).

Additionally, it looks like both tabs and spaces were used as indentation in this like, so I've fixed this in order to improve code look with default github's tabwidth=8 (commit# ac1df59 https://github.com/mnezerka/dnslib/commit/ac1df59079d75740cefc92853b99ac78dadb6604 ).

Kind regards, Victor.

You can view, comment on, or merge this pull request online at:

https://github.com/mnezerka/dnslib/pull/3 Commit Summary

  • fakesrv: listen address parameter fixup
  • fakesrv: tabs and spaces cleanup

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mnezerka/dnslib/pull/3, or mute the thread https://github.com/notifications/unsubscribe-auth/AKayA5801JYPBTSVH4eBLUGp505Efur9ks5uepcMgaJpZM4W5dG4 .