cp.py _init has off-by-one error

mnick / scikit-tensor

Python library for multilinear algebra and tensor factorizations

GNU General Public License v3.0

401 stars 113 forks source link

cp.py _init has off-by-one error #22

Open FabianAicheler opened 8 years ago

FabianAicheler commented 8 years ago

Specifically, line 198 and 201 seem to consider too small ranges when initialising, leaving Uinit[0] with null values.

I didn't look into why this seems to work when using default settings. But it did crash my custom code using another matrix factorization method, leading me to believe that Uinit[0] really is meant to be initialized?

I.e. should be "for n in range(0, N)"

paulrigor commented 7 years ago

Can you share a code sample? Thanks! @FabianAicheler