search

mnick / scikit-tensor

Python library for multilinear algebra and tensor factorizations
GNU General Public License v3.0
401 stars 113 forks source link

Added cp-apr algorithm in https://arxiv.org/pdf/1112.2414.pdf #28

Closed brianholland closed 7 years ago

brianholland commented 7 years ago

Thanks also to @theosotr

theosotr commented 7 years ago

What's the need of another pull request? I suggest to give you access to my repo and push here, because I believe I have primary contributions here.

brianholland commented 7 years ago

Sure, we can proceed as you like. If I understand correctly: I'd push to you, you'd give mnick a pull request on this one (cp-apr). There were a couple of things I'd left comments on you your copy that I addressed in my version and also made defaults along the lines of the style already there, that's about it.

theosotr commented 7 years ago

@brianholland You have write access to https://github.com/theosotr/scikit-tensor

brianholland commented 7 years ago

Closed pull request since 1) failed CI and 2) to coordinate with @theosotr