mnikhil-git / mscgen

Automatically exported from code.google.com/p/mscgen
GNU General Public License v2.0
0 stars 0 forks source link

Before/At next release. #21

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Hi

This is merely a reminder of misc./small things that should be fixed before
or at next release. I felt it was a bit much to open a separate issue these
things.

Before next release:

 * Deal with license for test/testinput9.msc.

At next release:

 * Update home page (under "The Software") - The library has been removed, etc.

~Niels

Original issue reported on code.google.com by NThykier@gmail.com on 27 Jul 2009 at 10:46

GoogleCodeExporter commented 8 years ago
Cool - thanks for making a note of this.

Original comment by Michael....@gmail.com on 28 Jul 2009 at 7:09

GoogleCodeExporter commented 8 years ago
Testinput9.msc is now fixed.

Original comment by Michael....@gmail.com on 2 Aug 2009 at 12:11

GoogleCodeExporter commented 8 years ago
Hi

Nice that testinput9 has been fixed.

Also, could I have you add these two lines to configure.ac? (second argument 
may need
some revising.)

AC_ARG_VAR([GDLIB_CFLAGS], [Added to CFLAGS if pkg-config does not have any 
useful
information.])
AC_ARG_VAR([GDLIB_LIBS], [Added to LDFLAGS if pkg-config does not have nay 
useful
information.])

They will make configure "aware" of these two variables, (e.g. verify that did 
not
change since "last" run like it does with CFLAGS). This avoids issues with 
people
using the cache options and it adds them to the "configure --help" output (that 
is
that the second argument does). 

~Niels

Original comment by NThykier@gmail.com on 2 Aug 2009 at 5:40

GoogleCodeExporter commented 8 years ago
I just tried adding them, and noticed that the help text didn't come out in 
configure
--help.  Instead the text that the pkgconf macro produces appears:

  PKG_CONFIG  path to pkg-config utility
  PKG_CONFIG_PATH
              directories to add to pkg-config's search path
  PKG_CONFIG_LIBDIR
              path overriding pkg-config's built-in search path
  GDLIB_CFLAGS
              C compiler flags for GDLIB, overriding pkg-config
  GDLIB_LIBS  linker flags for GDLIB, overriding pkg-config

So I tried diffing the configure script between when the AC_ARG_VARs are in and 
out,
and with the exception of white space, nothing changed.  This was with 
autoreconf-2.63.

Checking pkg.m4, which defines the macro I'm using, it looks to already be using
AC_ARG_VAR() in the PKG_CHECK_MODULES definition, so for once it looks like 
autoconf
has done the right thing and made it easy :)

Original comment by Michael....@gmail.com on 2 Aug 2009 at 6:02

GoogleCodeExporter commented 8 years ago
Yeah, I noticed after posted... I had hoped I deleted my comment in time, but 
no such
luck I guess. :P

Guess I will have to undelete my comment now.

~Niels

Original comment by NThykier@gmail.com on 2 Aug 2009 at 6:14

GoogleCodeExporter commented 8 years ago
Not to worry; it was an education for me to poke around those .m4 files ;)

Original comment by Michael....@gmail.com on 2 Aug 2009 at 6:23

GoogleCodeExporter commented 8 years ago

Original comment by Michael....@gmail.com on 31 Aug 2009 at 7:25