mnikhil-git / mscgen

Automatically exported from code.google.com/p/mscgen
GNU General Public License v2.0
0 stars 0 forks source link

More reduce-the-maintenance cleanup #28

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Another patch to reduce the maintenance in examples/Makefile.am:

Index: examples/Makefile.am
===========================================================
========
--- examples/Makefile.am    (revision 91)
+++ examples/Makefile.am    (working copy)
@@ -20,8 +20,4 @@

 CLEANFILES = $(BUILT_SOURCES)

-EXTRA_DIST = msg_types.mscin \
-             boxes_example.mscin \
-             colour_sample.mscin \
-             simple_prog_desc.mscin
-
+EXTRA_DIST = $(patsubst %.msc,%.mscin,$(BUILT_SOURCES))

Original issue reported on code.google.com by chickena...@gmail.com on 24 Aug 2009 at 8:29

GoogleCodeExporter commented 8 years ago
This one didn't work for me:

$ ./autogen.sh
aclocal
autoconf
autoheader
automake
examples/Makefile.am:23: patsubst %.msc, %.mscin, $(BUILD_SOURCES: non-POSIX 
variable
name
examples/Makefile.am:23: (probably a GNU make extension)
$ automake --version
automake (GNU automake) 1.11
Copyright (C) 2009 Free Software Foundation, Inc.
License GPLv2+: GNU GPL version 2 or later 
<http://gnu.org/licenses/gpl-2.0.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Written by Tom Tromey <tromey@redhat.com>
       and Alexandre Duret-Lutz <adl@gnu.org>.
$

What version of automake/conf are you using?

Original comment by Michael....@gmail.com on 24 Aug 2009 at 8:44

GoogleCodeExporter commented 8 years ago
Sorry, it *is* a gnu-ism, so I can see Automake refusing it now that I think 
about it.  I've got automake-1.10, but 
it's from Apple XCode so it might have extra chewy goodness in it.  I should 
limit it to Automake tricks so that it 
can still generate workable Makefile.in, but would require gnu only on the 
maintainer-side.

Original comment by chickena...@gmail.com on 24 Aug 2009 at 8:50

GoogleCodeExporter commented 8 years ago
Okay.  Would have been a nice one to avoid the duplication, but I guess we'll 
have to
stick with the long-hand version for portability.  Thanks for the suggestion in 
any
case :)

Original comment by Michael....@gmail.com on 24 Aug 2009 at 8:56