mnikhil-git / mscgen

Automatically exported from code.google.com/p/mscgen
GNU General Public License v2.0
0 stars 0 forks source link

URLs to be included in the SVG output #76

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What version of mscgen are you using? On what operating system?

Mscgen version 0.20
Windows 7 64bit

What enhancement would you like?

The URL attribute to be in the output in the SVG. At the moment it is 
discarded. 

Please see the example input and desired output vs. current output in the 
attachment.

I think it ought to be pretty simple to add. There are only 2 steps:

1) To enable linking, add xmlns:xlink="http://www.w3.org/1999/xlink" to the 
<svg> element at the start of the file:

2) To add the URLs themselves, add them as an <a xlink:href="..."></a> around 
the SVG elements that correspond to the MSC element tagged with the URL. I 
think it's better to enclose the whole of the arc or box rather than just the 
text.

Original issue reported on code.google.com by dunbar....@gmail.com on 8 Nov 2012 at 1:04

Attachments:

GoogleCodeExporter commented 8 years ago
I made some changes that implement the fix you requested (I needed the same 
thing).
See the attached patch which was based on version 0.20.
It worked for me, but I'm unable to run the tests as I don't have GD on my 
build server (I'm building with --without-png).

The changes were sent to the author over a month ago, but sadly I got no reply.

Original comment by chris.ba...@basirk.com on 22 May 2014 at 1:09

Attachments:

GoogleCodeExporter commented 8 years ago
Thanks for the patch. I'll see if I can build it. Last time I tried to build I 
couldn't get all the dependencies I needed in place.

Original comment by dunbar....@gmail.com on 28 May 2014 at 4:17

GoogleCodeExporter commented 8 years ago
Thanks for the details on how to add the links to the SVG output.  
I checked the patch and got the idea, but implemented it a bit differently in 
the end.
Sorry it took so long to review.

Original comment by Michael....@gmail.com on 24 Jan 2015 at 6:57

GoogleCodeExporter commented 8 years ago
This issue was closed by revision r204.

Original comment by Michael....@gmail.com on 24 Jan 2015 at 6:57