mnill / cordova-app-updater

Simple plugin for hot update cordova app
MIT License
16 stars 5 forks source link

Englishify readme #1

Closed wswoodruff closed 9 years ago

wswoodruff commented 9 years ago

Also, the trailing comma in the config.json example caused a sneaky JSON parse error. It said something about all properties needing to be string literals, so I was debugging that but really the trailing comma was telling JSON.parse that we were trying to specify another property. Anyway, removing the comma fixes it!

wswoodruff commented 9 years ago

I think that apache fixed the "cordova-plugin-file" plugin for getting readonly access Android, since it works for me.

wswoodruff commented 9 years ago

Oops, sorry didn't mean to close it

mnill commented 9 years ago

Hi! Thank for pull request! Trailing comma and comments in example json is really my terrible mistake :-(

I'm just needs to test cordova plugin file, before merge fixes.

mnill commented 9 years ago

Are you sure about file plugin? It is still not work correctly for me.

May be you just already have valid cache, create by my version of plugin? Can you please increment version in server config.json and try to relaunch the app?

wswoodruff commented 9 years ago

mnill I'm going to verify this later on today to make sure. I think I had to grab the plugin from their github page, but I'll make sure and let you know.

mnill commented 9 years ago

my fork installs with the same name

wswoodruff commented 9 years ago

Hmm, I think you're right it was probably in my cache. If I find out otherwise later, I'll provide something more detailed to reproduce. Thanks for your work on this awesome updater plugin and for extending the cordova file plugin!

wswoodruff commented 9 years ago

I put back the link to your fork of cordova-plugin-file in the readme