search

mnill / cordova-app-updater

Simple plugin for hot update cordova app
MIT License
16 stars 5 forks source link

Use of splashcreen #8

Closed khamaileon closed 8 years ago

khamaileon commented 8 years ago

I already use a splashcreen in my project that I'm hiding.

<preference name="AutoHideSplashScreen" value="false" />
<preference name="FadeSplashScreenDuration" value="1000" />
<preference name="UpdaterPolicy" value="tryupdate" />
<preference name="UpdaterHideSplashScreen" value="false" />
platform.ready()
  .then(log.info('platform ready'))
  .then(() => this.getOrCreateUser(this))
  .then(() => this.getOrCreateDevice(this))
  .then(device => this.registerNotification(device))
  .then(() => navigator.splashscreen.hide());

I tried UpdaterHideSplashScreen = true but my splashcreen does not hide. With UpdaterHideSplashScreen = false, the hiding is not triggered by me. And I never saw the updating progress as mentioned in the documentation.

mnill commented 8 years ago

What you mean "And I never saw the updating progress as mentioned in the documentation." ? Visualization not realized yet

mnill commented 8 years ago

I will make some type of updating screen in near future.

mnill commented 8 years ago

About splash screen I don't clearly understood you, but I will test it tomorrow.

khamaileon commented 8 years ago

I would like the splash screen to be hidden by me and not by cordova-app-updater. With UpdaterHideSplashScreen at True, the splash screen never hides. WIth UpdaterHideSplashScreen at False, the splash is hidden at the end of the updating process and not when I ask for it. Wouldn't it be better if the splash screen is no longer controlled by the plug-in ?

mnill commented 8 years ago

I think i repaired this issue, thanks for reporting.

I want to make 'updating in progress' page template in near future. For long updates. It is a reason to keep this parameter.

khamaileon commented 8 years ago

Thanks @mnill. It's OK now!