search

mnimish / tempConverter

Temperature Converter
0 stars 0 forks source link

Review my app #1

Open mnimish opened 11 years ago

mnimish commented 11 years ago

My app is a complete, please review. As keypad was hiding the conver button, I have added some basic animation. Is that the right way to do it? /cc @nesquena @timothy1ee

timothy1ee commented 11 years ago

Great, looks good, glad you played with animations, that is the correct way to do it. Note that the convert button is still obscured by the keyboard in the 3.5" (iPhone 4S). You need to make the logic robust to different phone heights. Also, it's common to do animations that match the keyboard, but the animation duration should be the same duration as the keyboard, otherwise it looks out of sync.